Chromium Code Reviews Chromium Code Reviews
Issue
231933004:
Fix a broken test which calls Selection.setPosition(null). (Closed)
DescriptionFix a broken test which calls Selection.setPosition(null).
This test was copied from a sibling test:
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/editing/execCommand/indent-images-2.html
This test calls document.getElementsByTagName('div') but there are no div elements.
As a result, test calls Selection.setPosition(null) and it is clearly not intended.
This test uses a span element instead of div element which is targeted in the indent-images-2.html.
Thus this CL rewrite 'div' to 'span'.
This test originally expects that execCommand('indent') should not indent contents inside inline block.
However fixed case, which works as intended, indents the contents.
This CL does only fix broken scripts.
We already started discussion about the execCommand behavior.
If we should change the implementation, we will do it on another patch.
BUG=361911
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171745
Patch Set 1 #
Total comments: 2
Patch Set 2 : Modify typo #
Messages
Total messages: 13 (0 generated)
|
||||||||||||||||||||||||||||
