LayoutTests/editing/execCommand/indent-images-3.html - Issue 231933004: Fix a broken test which calls Selection.setPosition(null).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/indent-images-3.html

Issue 231933004: Fix a broken test which calls Selection.setPosition(null). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modify typo Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body><span contenteditable><img><img></span>	3 <body><span contenteditable><img><img></span>

4 <script src="../../resources/dump-as-markup.js"></script>	4 <script src="../../resources/dump-as-markup.js"></script>

5 <script>	5 <script>

6	6

7 if (window.testRunner)	7 if (window.testRunner)

8 testRunner.dumpAsText();	8 testRunner.dumpAsText();

9	9

10 while (script = document.querySelector('script'))	10 while (script = document.querySelector('script'))

11 script.parentNode.removeChild(script);	11 script.parentNode.removeChild(script);

12	12

13 getSelection().setPosition(document.getElementsByTagName('div')[0], 2);	13 getSelection().setPosition(document.getElementsByTagName('span')[0], 2);

14 document.execCommand('indent');	14 document.execCommand('indent');

15	15

16 Markup.description('This test indents insides a document with exactly two image elements.\n'	16 Markup.description('This test indents insides a document with exactly two image elements.\n'

17 + 'Indentation should fail because the root editable element is inline.');	17 + 'Indentation should succeed even if the root editable element is inline.');

18 Markup.dump(document.body);	18 Markup.dump(document.body);

19	19

20 </script>	20 </script>

21 </body>	21 </body>

22 </html>	22 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/execCommand/indent-images-3-expected.txt » ('j') | no next file with comments »