Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231933003: SkRecordDraw: don't bother clipping an empty clip down further (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@clipping
Visibility:
Public.

Description

SkRecordDraw: don't bother clipping an empty clip down further BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14126

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M src/record/SkRecordDraw.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M tests/RecordDrawTest.cpp View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
As per your suggestion...
6 years, 8 months ago (2014-04-09 22:04:36 UTC) #1
fmalita_google_do_not_use
6 years, 8 months ago (2014-04-09 22:16:01 UTC) #2
fmalita_google_do_not_use
lgtm
6 years, 8 months ago (2014-04-09 22:19:56 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-09 23:37:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/231933003/20001
6 years, 8 months ago (2014-04-09 23:37:26 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 02:26:35 UTC) #6
Message was sent while issue was closed. 
Change committed as 14126

Powered by Google App Engine
This is Rietveld 408576698