Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: tests/RecordDrawTest.cpp

Issue 231933003: SkRecordDraw: don't bother clipping an empty clip down further (Closed) Base URL: https://skia.googlesource.com/skia.git@clipping
Patch Set: add test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/record/SkRecordDraw.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/RecordDrawTest.cpp
diff --git a/tests/RecordDrawTest.cpp b/tests/RecordDrawTest.cpp
index 6468e72c9d5c6d2f3e1e5e686f2932c45e95cca3..98ec506b1ed66dc81dccddd29b336d83eed2f526 100644
--- a/tests/RecordDrawTest.cpp
+++ b/tests/RecordDrawTest.cpp
@@ -43,14 +43,15 @@ DEF_TEST(RecordDraw_Clipping, r) {
SkRecord record;
SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record, W, H);
- // 8 draw commands.
- // The inner clipRect makes the clip empty, so the inner drawRect does nothing.
+ // 9 draw commands.
recorder.save();
recorder.clipRect(SkRect::MakeLTRB(0, 0, 100, 100));
recorder.drawRect(SkRect::MakeLTRB(20, 20, 40, 40), SkPaint());
recorder.save();
+ // This first clipRect makes the clip empty, so the next two commands do nothing.
recorder.clipRect(SkRect::MakeLTRB(200, 200, 300, 300));
- recorder.drawRect(SkRect::MakeLTRB(220, 220, 240, 240), SkPaint());
+ recorder.clipRect(SkRect::MakeLTRB(210, 210, 250, 250)); // Skipped
+ recorder.drawRect(SkRect::MakeLTRB(220, 220, 240, 240), SkPaint()); // Skipped
recorder.restore();
recorder.restore();
@@ -59,6 +60,6 @@ DEF_TEST(RecordDraw_Clipping, r) {
SkRecorder rerecorder(SkRecorder::kReadWrite_Mode, &rerecord, W, H);
SkRecordDraw(record, &rerecorder);
- // All commands except the drawRect will be preserved.
+ // All commands except the two marked // Skipped above will be preserved.
REPORTER_ASSERT(r, 7 == rerecord.count());
}
« no previous file with comments | « src/record/SkRecordDraw.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698