Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/gyp/apkbuilder.py

Issue 2319273002: Make secondary abi work for component build (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/BUILD.gn ('K') | « build/android/BUILD.gn ('k') | build/android/gyp/write_build_config.py » ('j') | build/android/gyp/write_build_config.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/apkbuilder.py
diff --git a/build/android/gyp/apkbuilder.py b/build/android/gyp/apkbuilder.py
index 82ac496ed970039ed34bd51af0e06c64b88d91f4..41b54c0612e15b7bf214e08216a19ef429119493 100755
--- a/build/android/gyp/apkbuilder.py
+++ b/build/android/gyp/apkbuilder.py
@@ -190,7 +190,7 @@ def main(args):
if options.secondary_native_libs:
secondary_native_libs = sorted(options.secondary_native_libs)
input_paths += secondary_native_libs
- depfile_deps += secondary_native_libs
+ depfile_deps += list(secondary_native_libs)
agrieve 2016/09/08 01:02:15 Does this do anything?
michaelbai 2016/09/08 18:52:50 No difference, I wanted to match the native_libs,
if options.dex_file:
input_paths.append(options.dex_file)
« build/android/BUILD.gn ('K') | « build/android/BUILD.gn ('k') | build/android/gyp/write_build_config.py » ('j') | build/android/gyp/write_build_config.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698