Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: build/android/gyp/apkbuilder.py

Issue 2319273002: Make secondary abi work for component build (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright (c) 2015 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Adds the code parts to a resource APK.""" 7 """Adds the code parts to a resource APK."""
8 8
9 import argparse 9 import argparse
10 import itertools 10 import itertools
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 183
184 input_paths = [options.resource_apk, __file__] + native_libs 184 input_paths = [options.resource_apk, __file__] + native_libs
185 # Include native libs in the depfile_deps since GN doesn't know about the 185 # Include native libs in the depfile_deps since GN doesn't know about the
186 # dependencies when is_component_build=true. 186 # dependencies when is_component_build=true.
187 depfile_deps = list(native_libs) 187 depfile_deps = list(native_libs)
188 188
189 secondary_native_libs = [] 189 secondary_native_libs = []
190 if options.secondary_native_libs: 190 if options.secondary_native_libs:
191 secondary_native_libs = sorted(options.secondary_native_libs) 191 secondary_native_libs = sorted(options.secondary_native_libs)
192 input_paths += secondary_native_libs 192 input_paths += secondary_native_libs
193 depfile_deps += secondary_native_libs 193 depfile_deps += list(secondary_native_libs)
agrieve 2016/09/08 01:02:15 Does this do anything?
michaelbai 2016/09/08 18:52:50 No difference, I wanted to match the native_libs,
194 194
195 if options.dex_file: 195 if options.dex_file:
196 input_paths.append(options.dex_file) 196 input_paths.append(options.dex_file)
197 197
198 if options.emma_device_jar: 198 if options.emma_device_jar:
199 input_paths.append(options.emma_device_jar) 199 input_paths.append(options.emma_device_jar)
200 200
201 input_strings = [options.android_abi, 201 input_strings = [options.android_abi,
202 options.native_lib_placeholders, 202 options.native_lib_placeholders,
203 options.uncompress_shared_libraries] 203 options.uncompress_shared_libraries]
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 on_stale_md5, 302 on_stale_md5,
303 options, 303 options,
304 input_paths=input_paths, 304 input_paths=input_paths,
305 input_strings=input_strings, 305 input_strings=input_strings,
306 output_paths=[options.output_apk], 306 output_paths=[options.output_apk],
307 depfile_deps=depfile_deps) 307 depfile_deps=depfile_deps)
308 308
309 309
310 if __name__ == '__main__': 310 if __name__ == '__main__':
311 main(sys.argv[1:]) 311 main(sys.argv[1:])
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698