Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 2319233002: Have setters use strict -> like methods (Closed)

Created:
4 years, 3 months ago by Jennifer Messerly
Modified:
4 years, 3 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 chunk +8 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/dev_compiler/test/codegen/language/abstract_method_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen/language/field_override4_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
Noticed this inconsistency while investigating covariant overrides
4 years, 3 months ago (2016-09-07 20:07:16 UTC) #2
Leaf
lgtm
4 years, 3 months ago (2016-09-07 20:31:13 UTC) #3
Jennifer Messerly
4 years, 3 months ago (2016-09-07 21:01:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6d31434983ca4aee17affee054681666d798ce9a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698