Have setters use strict -> like methods

pkg/analyzer/test/src/task/strong/checker_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.src.task.strong.checker_test;
 
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import 'strong_test_helper.dart';
 
@@ skipping 568 matching lines @@
   B f1;
   B f2;
   B f3;
   B f4;
 }
 
 class Child extends Base {
   /*error:INVALID_FIELD_OVERRIDE,error:INVALID_METHOD_OVERRIDE*/A f1; // invalid for getter
   /*error:INVALID_FIELD_OVERRIDE,error:INVALID_METHOD_OVERRIDE*/C f2; // invalid for setter
   /*error:INVALID_FIELD_OVERRIDE*/var f3;
-  /*error:INVALID_FIELD_OVERRIDE,error:INVALID_METHOD_OVERRIDE,error:INVALID_METHOD_OVERRIDE*/dynamic f4;
+  /*error:INVALID_FIELD_OVERRIDE,error:INVALID_METHOD_OVERRIDE*/dynamic f4;
 }
 
 class Child2 implements Base {
   /*error:INVALID_METHOD_OVERRIDE*/A f1; // invalid for getter
   /*error:INVALID_METHOD_OVERRIDE*/C f2; // invalid for setter
   var f3;
-  /*error:INVALID_METHOD_OVERRIDE,error:INVALID_METHOD_OVERRIDE*/dynamic f4;
+  /*error:INVALID_METHOD_OVERRIDE*/dynamic f4;
 }
 ''');
   }
 
   void test_fieldGetterOverride() {
     checkFile('''
 class A {}
 class B extends A {}
 class C extends B {}
 
@@ skipping 57 matching lines @@
 class Child extends Base {
   /*error:INVALID_FIELD_OVERRIDE*/B get f1 => null;
   /*error:INVALID_FIELD_OVERRIDE*/B get f2 => null;
   /*error:INVALID_FIELD_OVERRIDE*/B get f3 => null;
   /*error:INVALID_FIELD_OVERRIDE*/B get f4 => null;
   /*error:INVALID_FIELD_OVERRIDE*/B get f5 => null;
 
   /*error:INVALID_FIELD_OVERRIDE*/void set f1(A value) {}
   /*error:INVALID_FIELD_OVERRIDE,error:INVALID_METHOD_OVERRIDE*/void set f2(C value) {}
   /*error:INVALID_FIELD_OVERRIDE*/void set f3(value) {}
-  /*error:INVALID_FIELD_OVERRIDE,error:INVALID_METHOD_OVERRIDE*/void set f4(dynamic value) {}
+  /*error:INVALID_FIELD_OVERRIDE*/void set f4(dynamic value) {}
   /*error:INVALID_FIELD_OVERRIDE*/set f5(B value) {}
 }
 
 class Child2 implements Base {
   B get f1 => null;
   B get f2 => null;
   B get f3 => null;
   B get f4 => null;
   B get f5 => null;
 
   void set f1(A value) {}
   /*error:INVALID_METHOD_OVERRIDE*/void set f2(C value) {}
   void set f3(value) {}
-  /*error:INVALID_METHOD_OVERRIDE*/void set f4(dynamic value) {}
+  void set f4(dynamic value) {}
   set f5(B value) {}
 }
 ''');
   }
 
   void test_forInCastsIterateElementToVariable() {
     checkFile('''
 main() {
   // Don't choke if sequence is not iterable.
   for (var i in /*error:FOR_IN_OF_INVALID_TYPE*/1234) {}
@@ skipping 2480 matching lines @@
 class F {
   void set f(ToVoid<dynamic> x) {}
   void set g(ToVoid<int> x) {}
   void set h(dynamic x) {}
   void set i(int x) {}
 }
 
 class G extends F {
   /*error:INVALID_METHOD_OVERRIDE*/void set f(ToVoid<int> x) {}
   void set g(ToVoid<dynamic> x) {}
-  void set h(int x) {}
-  /*error:INVALID_METHOD_OVERRIDE*/void set i(dynamic x) {}
+  /*error:INVALID_METHOD_OVERRIDE*/void set h(int x) {}
+  void set i(dynamic x) {}
 }
 
 class H implements F {
   /*error:INVALID_METHOD_OVERRIDE*/void set f(ToVoid<int> x) {}
   void set g(ToVoid<dynamic> x) {}
-  void set h(int x) {}
-  /*error:INVALID_METHOD_OVERRIDE*/void set i(dynamic x) {}
+  /*error:INVALID_METHOD_OVERRIDE*/void set h(int x) {}
+  void set i(dynamic x) {}
 }
  ''');
   }
 
   void test_setterReturnTypes() {
     checkFile('''
 void voidFn() => null;
 class A {
   set a(y) => 4;
   set b(y) => voidFn();
@@ skipping 20 matching lines @@
   void set f2(B value);
   void set f3(B value);
   void set f4(B value);
   void set f5(B value);
 }
 
 class Child extends Base {
   void set f1(A value) {}
   /*error:INVALID_METHOD_OVERRIDE*/void set f2(C value) {}
   void set f3(value) {}
-  /*error:INVALID_METHOD_OVERRIDE*/void set f4(dynamic value) {}
+  void set f4(dynamic value) {}
   set f5(B value) {}
 }
 ''');
   }
 
   void test_superCallPlacement() {
     checkFile('''
 class Base {
   var x;
   Base() : x = print('Base.1') { print('Base.2'); }
@@ skipping 478 matching lines @@
     // Regression test for https://github.com/dart-lang/sdk/issues/25069
     checkFile('''
 typedef int Foo();
 void foo() {}
 void main () {
   Foo x = /*error:INVALID_ASSIGNMENT,info:USE_OF_VOID_RESULT*/foo();
 }
 ''');
   }
 }