If tab is created from chrome UI, don't mark the tab as external app

If tab is created from chrome UI, don't mark the tab as external app

All tabs created by TabDelegate.createNewTab() are treated as from external
apps.
However, if the tab was created from Chrome's own UI, we shouldn't do
this.
Otherwise, clicking the back button will dismiss the Chrome app.
This change also passes the header String when creating a new tab.
This allows Chrome UI to create tabs with correct header Strings.

BUG=637239
Committed: https://crrev.com/267017bd9bf22827603d0a2446d2912e7ec0ca50
Cr-Commit-Position: refs/heads/master@{#417204}

[qinmin, 2016-09-07 21:45:54]

qinmin@chromium.org changed reviewers:
+ dfalcantara@chromium.org, fgorski@chromium.org

[qinmin, 2016-09-07 21:45:54]

PTAL

[fgorski, 2016-09-07 21:54:28]

lgtm

[gone, 2016-09-07 23:19:41]

https://chromiumcodereview.appspot.com/2319143004/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
(right):

https://chromiumcodereview.appspot.com/2319143004/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java:217:
* {@link #createNewTab} with the default {@link LoadUrlParams} and no parent
tab.
Not very convenient at this point... should the callers that need headers just
pass in a LoadUrlParams?

[qinmin, 2016-09-08 00:13:18]

https://chromiumcodereview.appspot.com/2319143004/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
(right):

https://chromiumcodereview.appspot.com/2319143004/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java:217:
* {@link #createNewTab} with the default {@link LoadUrlParams} and no parent
tab.
On 2016/09/07 23:19:41, dfalcantara wrote:
> Not very convenient at this point... should the callers that need headers just
> pass in a LoadUrlParams?

Done. Making createNewTab public so that the caller can use that method to pass
in a LoadUrlParams

[gone, 2016-09-08 00:14:20]

lgtm

[qinmin, 2016-09-08 05:20:54]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-09-08 05:20:55]

The patchset sent to the CQ was uploaded after l-g-t-m from fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2319143004/#ps20001
(title: "making createNewTab public")

[commit-bot: I haz the power, 2016-09-08 05:21:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 06:08:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 06:09:36]

Description was changed from

==========
If tab is created from chrome UI, don't mark the tab as external app

All tabs created by TabDelegate.createNewTab() are treated as from external
apps.
However, if the tab was created from Chrome's own UI, we shouldn't do
this.
Otherwise, clicking the back button will dismiss the Chrome app.
This change also passes the header String when creating a new tab.
This allows Chrome UI to create tabs with correct header Strings.

BUG=637239
==========

to

==========
If tab is created from chrome UI, don't mark the tab as external app

All tabs created by TabDelegate.createNewTab() are treated as from external
apps.
However, if the tab was created from Chrome's own UI, we shouldn't do
this.
Otherwise, clicking the back button will dismiss the Chrome app.
This change also passes the header String when creating a new tab.
This allows Chrome UI to create tabs with correct header Strings.

BUG=637239

Committed: https://crrev.com/267017bd9bf22827603d0a2446d2912e7ec0ca50
Cr-Commit-Position: refs/heads/master@{#417204}
==========

[commit-bot: I haz the power, 2016-09-08 06:09:37]

Patchset 2 (id:??) landed as
https://crrev.com/267017bd9bf22827603d0a2446d2912e7ec0ca50
Cr-Commit-Position: refs/heads/master@{#417204}