chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java - Issue 2319143004: If tab is created from chrome UI, don't mark the tab as external app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 2319143004: If tab is created from chrome UI, don't mark the tab as external app (Closed)

Patch Set: making createNewTab public Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

index 194fbbe58d2e6eec14fccc17bd45f2ac59a97c83..6433e534c279cc5644105a66ffe504c5e926c73b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

@@ -80,7 +80,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {

* @param intent the source of the url if it isn't null.

* @return The new tab.

- private Tab createNewTab(LoadUrlParams loadUrlParams, TabModel.TabLaunchType type,

+ public Tab createNewTab(LoadUrlParams loadUrlParams, TabModel.TabLaunchType type,

Tab parent, Intent intent) {

// If parent is in the same tab model, place the new tab next to it.

int position = TabModel.INVALID_TAB_INDEX;