Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: components/omnibox/browser/physical_web_provider.h

Issue 2319033006: Include a page title in the Physical Web omnibox overflow item (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/physical_web_provider.h
diff --git a/components/omnibox/browser/physical_web_provider.h b/components/omnibox/browser/physical_web_provider.h
index d4e7486c73a869a861560e8c996a9f6c023e42ca..b6d9c1d08b57745b2bb9888a9e2e5df51a9ad99d 100644
--- a/components/omnibox/browser/physical_web_provider.h
+++ b/components/omnibox/browser/physical_web_provider.h
@@ -40,7 +40,8 @@ class PhysicalWebProvider : public AutocompleteProvider {
// |relevance| and a label indicating there are |additional_url_count| more
// nearby URLs. Selecting the overflow item navigates to the Physical Web
// WebUI, which displays the full list of nearby URLs.
- void AppendOverflowItem(int additional_url_count, int relevance);
+ void AppendOverflowItem(int additional_url_count, int relevance,
+ const std::string& title);
Mark P 2016/09/08 18:49:50 nit #1: the function comment should mention what |
mattreynolds 2016/09/09 21:24:54 Done.
AutocompleteProviderClient* client_;

Powered by Google App Engine
This is Rietveld 408576698