Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: components/omnibox/browser/physical_web_provider.h

Issue 2319033006: Include a page title in the Physical Web omnibox overflow item (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OMNIBOX_BROWSER_PHYSICAL_WEB_PROVIDER_H_ 5 #ifndef COMPONENTS_OMNIBOX_BROWSER_PHYSICAL_WEB_PROVIDER_H_
6 #define COMPONENTS_OMNIBOX_BROWSER_PHYSICAL_WEB_PROVIDER_H_ 6 #define COMPONENTS_OMNIBOX_BROWSER_PHYSICAL_WEB_PROVIDER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/omnibox/browser/autocomplete_input.h" 9 #include "components/omnibox/browser/autocomplete_input.h"
10 #include "components/omnibox/browser/autocomplete_provider.h" 10 #include "components/omnibox/browser/autocomplete_provider.h"
(...skipping 22 matching lines...) Expand all
33 // Adds a separate match item to |matches_| for each nearby URL in 33 // Adds a separate match item to |matches_| for each nearby URL in
34 // |metadata_list|, up to the maximum number of matches allowed. If the total 34 // |metadata_list|, up to the maximum number of matches allowed. If the total
35 // number of nearby URLs exceeds this limit, one match is used for an overflow 35 // number of nearby URLs exceeds this limit, one match is used for an overflow
36 // item. 36 // item.
37 void ConstructMatches(base::ListValue* metadata_list); 37 void ConstructMatches(base::ListValue* metadata_list);
38 38
39 // Adds an overflow match item to |matches_| with a relevance score equal to 39 // Adds an overflow match item to |matches_| with a relevance score equal to
40 // |relevance| and a label indicating there are |additional_url_count| more 40 // |relevance| and a label indicating there are |additional_url_count| more
41 // nearby URLs. Selecting the overflow item navigates to the Physical Web 41 // nearby URLs. Selecting the overflow item navigates to the Physical Web
42 // WebUI, which displays the full list of nearby URLs. 42 // WebUI, which displays the full list of nearby URLs.
43 void AppendOverflowItem(int additional_url_count, int relevance); 43 void AppendOverflowItem(int additional_url_count, int relevance,
44 const std::string& title);
Mark P 2016/09/08 18:49:50 nit #1: the function comment should mention what |
mattreynolds 2016/09/09 21:24:54 Done.
44 45
45 AutocompleteProviderClient* client_; 46 AutocompleteProviderClient* client_;
46 47
47 // Used for efficiency when creating the verbatim match. Can be null. 48 // Used for efficiency when creating the verbatim match. Can be null.
48 HistoryURLProvider* history_url_provider_; 49 HistoryURLProvider* history_url_provider_;
49 50
50 DISALLOW_COPY_AND_ASSIGN(PhysicalWebProvider); 51 DISALLOW_COPY_AND_ASSIGN(PhysicalWebProvider);
51 }; 52 };
52 53
53 #endif // COMPONENTS_OMNIBOX_BROWSER_PHYSICAL_WEB_PROVIDER_H_ 54 #endif // COMPONENTS_OMNIBOX_BROWSER_PHYSICAL_WEB_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698