[Offline pages] Fixing crash happening when 2 pages get saved about the same time

[Offline pages] Fixing crash happening when 2 pages get saved about the same time

* Ensuring OPDownloadBridge is properly destroyed in TabletToolbar.java
* Removing CHECK from DownloadUIAdapter::OnOfflinePagesChanged as in situation
  when 2 pages get saved quickly one after another, it may carry 2
  changed guids instead of one.

BUG=638897
Committed: https://crrev.com/738611d189e706c5436ef7cf5efa3ccd3839fa67
Cr-Commit-Position: refs/heads/master@{#417110}

[fgorski, 2016-09-07 21:49:39]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 21:50:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-09-07 21:51:31]

fgorski@chromium.org changed reviewers:
+ dfalcantara@chromium.org, dimich@chromium.org

[fgorski, 2016-09-07 21:51:31]

PTAL

[gone, 2016-09-07 22:04:30]

https://codereview.chromium.org/2318933004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
(right):

https://codereview.chromium.org/2318933004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java:311:
// This is a temporary hookup point to save a page later.
This is the permanent hookup point, as far as I can tell.  Remove the comment?

https://codereview.chromium.org/2318933004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java:315:
bridge.destroy();
Should this just be combined with ChromeActivity#onMenuOrKeyboardAction()'s
implementation of this almost-exact same thing?  The only difference is the
metric name.

[gone, 2016-09-07 22:12:24]

lgtm given merge requirement

[Dmitry Titov, 2016-09-07 22:16:49]

lgtm

lets remove the CHECK whatsoever with the comment.

[fgorski, 2016-09-07 22:22:09]

addressed.

https://codereview.chromium.org/2318933004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
(right):

https://codereview.chromium.org/2318933004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java:311:
// This is a temporary hookup point to save a page later.
On 2016/09/07 22:04:30, dfalcantara wrote:
> This is the permanent hookup point, as far as I can tell.  Remove the comment?

Done.

https://codereview.chromium.org/2318933004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java:315:
bridge.destroy();
On 2016/09/07 22:04:30, dfalcantara wrote:
> Should this just be combined with ChromeActivity#onMenuOrKeyboardAction()'s
> implementation of this almost-exact same thing?  The only difference is the
> metric name.

Agreed, but hence I want to merge, I'll leave it to you and some other patch.
(Per our discussion.)

[fgorski, 2016-09-07 22:22:12]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-09-07 22:22:13]

The patchset sent to the CQ was uploaded after l-g-t-m from dimich@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2318933004/#ps20001
(title: "Addressing CR feedback")

[commit-bot: I haz the power, 2016-09-07 22:22:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:09:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 23:11:35]

Description was changed from

==========
[Offline pages] Fixing crash happening when 2 pages get saved about the same
time

* Ensuring OPDownloadBridge is properly destroyed in TabletToolbar.java
* Removing CHECK from DownloadUIAdapter::OnOfflinePagesChanged as in situation
  when 2 pages get saved quickly one after another, it may carry 2
  changed guids instead of one.

BUG=638897
==========

to

==========
[Offline pages] Fixing crash happening when 2 pages get saved about the same
time

* Ensuring OPDownloadBridge is properly destroyed in TabletToolbar.java
* Removing CHECK from DownloadUIAdapter::OnOfflinePagesChanged as in situation
  when 2 pages get saved quickly one after another, it may carry 2
  changed guids instead of one.

BUG=638897

Committed: https://crrev.com/738611d189e706c5436ef7cf5efa3ccd3839fa67
Cr-Commit-Position: refs/heads/master@{#417110}
==========

[commit-bot: I haz the power, 2016-09-07 23:11:36]

Patchset 2 (id:??) landed as
https://crrev.com/738611d189e706c5436ef7cf5efa3ccd3839fa67
Cr-Commit-Position: refs/heads/master@{#417110}