Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

Issue 2318933004: [Offline pages] Fixing crash happening when 2 pages get saved about the same time (Closed)
Patch Set: Addressing CR feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/offline_pages/downloads/download_ui_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
index 3c3b442f0314e103fb568524736fc0b27aedc09c..297bcb7428fc618ae9cf569acbb3b5d082bc12f6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
@@ -75,10 +75,6 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
private NewTabPage mVisibleNtp;
- // TODO(twellington): Once incognito is supported, we will need one OfflinePageDownloadBridges
- // for each profile (normal and incognito).
- private OfflinePageDownloadBridge mOfflinePageDownloadBridge;
-
/**
* Constructs a ToolbarTablet object.
* @param context The Context in which this View object is created.
@@ -312,12 +308,10 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
mTabSwitcherListener.onClick(mAccessibilitySwitcherButton);
}
} else if (mSaveOfflineButton == v) {
- // This is a temporary hookup point to save a page later.
Tab tab = getToolbarDataProvider().getTab();
- if (mOfflinePageDownloadBridge == null) {
- mOfflinePageDownloadBridge = new OfflinePageDownloadBridge(tab.getProfile());
- }
- mOfflinePageDownloadBridge.startDownload(tab);
+ OfflinePageDownloadBridge bridge = new OfflinePageDownloadBridge(tab.getProfile());
+ bridge.startDownload(tab);
+ bridge.destroy();
RecordUserAction.record("MobileToolbarDownloadPage");
DownloadUtils.recordDownloadPageMetrics(tab);
DownloadUtils.showDownloadStartToast(getContext());
« no previous file with comments | « no previous file | components/offline_pages/downloads/download_ui_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698