Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2318883002: Revert of Implement WTF::WeakPtr in terms of base::WeakPtr (Closed)

Created:
4 years, 3 months ago by hiroshige
Modified:
4 years, 3 months ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-wtf_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), gavinp+loader_chromium.org, Nate Chapin, jbroman, Justin Novosad, kinuko+watch, kouhei (in TOK), loading-reviews+parser_chromium.org, loading-reviews_chromium.org, Mikhail, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement WTF::WeakPtr in terms of base::WeakPtr (patchset #5 id:80001 of https://codereview.chromium.org/2300813003/ ) Reason for revert: Caused data races/crashes. BUG=643777 Original issue's description: > Implement WTF::WeakPtr in terms of base::WeakPtr > > BUG=none > > Committed: https://crrev.com/288b352ea69e3cff2540ac701bb181485d423192 > Cr-Commit-Position: refs/heads/master@{#416133} TBR=esprehn@chromium.org,csharrison@chromium.org,yoav@yoav.ws,dcheng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none Committed: https://crrev.com/977ec315e1cf4a68b1616be8419a150a92494549 Cr-Commit-Position: refs/heads/master@{#416838}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -41 lines) Patch
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 4 chunks +8 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +12 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/CrossThreadCopier.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Forward.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/WeakPtr.h View 1 chunk +109 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hiroshige
Created Revert of Implement WTF::WeakPtr in terms of base::WeakPtr
4 years, 3 months ago (2016-09-07 02:06:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318883002/1
4 years, 3 months ago (2016-09-07 02:07:07 UTC) #3
Charlie Harrison
LGTM is there an easy test case so dcheng can have an easier time relanding?
4 years, 3 months ago (2016-09-07 02:08:53 UTC) #4
hiroshige
On 2016/09/07 02:08:53, Charlie Harrison wrote: > LGTM is there an easy test case so ...
4 years, 3 months ago (2016-09-07 02:19:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 03:50:30 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 03:54:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/977ec315e1cf4a68b1616be8419a150a92494549
Cr-Commit-Position: refs/heads/master@{#416838}

Powered by Google App Engine
This is Rietveld 408576698