Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(50)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/Source/wtf/DEPS
Issue
2318883002
:
Revert of Implement WTF::WeakPtr in terms of base::WeakPtr (Closed)
Patch Set:
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h
third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp
third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
third_party/WebKit/Source/core/loader/ImageLoader.cpp
third_party/WebKit/Source/platform/CrossThreadCopier.h
third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp
third_party/WebKit/Source/wtf/DEPS
third_party/WebKit/Source/wtf/Forward.h
third_party/WebKit/Source/wtf/Functional.h
third_party/WebKit/Source/wtf/WeakPtr.h
View unified diff
|
Download patch
« no previous file with comments
|
« third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp
('k') |
third_party/WebKit/Source/wtf/Forward.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2 # To whitelist base/ stuff Blink is allowed to include, we list up all
2 # To whitelist base/ stuff Blink is allowed to include, we list up all
3 # directories and files instead of writing 'base/'.
3 # directories and files instead of writing 'base/'.
4 "+base/auto_reset.h",
4 "+base/auto_reset.h",
5 "+base/bind.h",
5 "+base/bind.h",
6 "+base/debug",
6 "+base/debug",
7 "+base/logging.h",
7 "+base/logging.h",
8
"+base/memory/weak_ptr.h",
9 "+base/numerics",
8 "+base/numerics",
10 "+base/optional.h",
9 "+base/optional.h",
11 "+base/rand_util.h",
10 "+base/rand_util.h",
12 "+base/strings",
11 "+base/strings",
13 "+base/threading/thread_checker.h",
12 "+base/threading/thread_checker.h",
14 "+base/time/time.h",
13 "+base/time/time.h",
15 "+base/tuple.h",
14 "+base/tuple.h",
16 "+build",
15 "+build",
17 ]
16 ]
OLD
NEW
« no previous file with comments
|
« third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp
('k') |
third_party/WebKit/Source/wtf/Forward.h »
('j') |
no next file with comments »
Issue 2318883002: Revert of Implement WTF::WeakPtr in terms of base::WeakPtr (Closed)
Created 4 years, 3 months ago by hiroshige
Modified 4 years, 3 months ago
Reviewers: esprehn, Charlie Harrison, Yoav Weiss, dcheng
Base URL:
Comments: 0
This is Rietveld
408576698