Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html

Issue 2318873002: [MD-Settings-A11y] cr-expand-button should communicate that it expanded. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
diff --git a/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html b/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
index 4e5047b0c6f74227ae7b724bdbcf0df641817cd2..a3f9fd8447eb831030998025843c6fa0908a19d6 100644
--- a/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
+++ b/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
@@ -8,7 +8,7 @@
<template>
<content></content>
<paper-icon-button toggles active="{{expanded}}" disabled="[[disabled]]"
- icon="[[iconName_(expanded)]]">
+ icon="[[iconName_(expanded)]]" aria-active-attribute="aria-expanded">
michaelpg 2016/09/07 22:38:42 shouldn't this reference *what* it expands?
hcarmona 2016/09/26 18:22:51 Only one screen reader supports this property and
</paper-icon-button>
</template>
<script src="cr_expand_button.js"></script>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698