ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html - Issue 2318873002: [MD-Settings-A11y] cr-expand-button should communicate that it expanded.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html

Issue 2318873002: [MD-Settings-A11y] cr-expand-button should communicate that it expanded. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html">	1 <link rel="import" href="chrome://resources/cr_elements/icons.html">

2 <link rel="import" href="chrome://resources/html/polymer.html">	2 <link rel="import" href="chrome://resources/html/polymer.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

4	4

5 <dom-module id="cr-expand-button">	5 <dom-module id="cr-expand-button">

6 <link rel="import" type="css" href="chrome://resources/cr_elements/shared.css" >	6 <link rel="import" type="css" href="chrome://resources/cr_elements/shared.css" >

7 <link rel="import" type="css" href="cr_expand_button.css">	7 <link rel="import" type="css" href="cr_expand_button.css">

8 <template>	8 <template>

9 <content></content>	9 <content></content>

10 <paper-icon-button toggles active="{{expanded}}" disabled="[[disabled]]"	10 <paper-icon-button toggles active="{{expanded}}" disabled="[[disabled]]"

11 icon="[[iconName_(expanded)]]">	11 icon="[[iconName_(expanded)]]" aria-active-attribute="aria-expanded">
	michaelpg 2016/09/07 22:38:42 shouldn't this reference what it expands? shouldn't this reference what it expands? Show quoted text > If the element with the aria-expanded attribute controls the expansion of another grouping container that is not 'owned by' the element, the author SHOULD reference the container by using the aria-controls attribute. https://www.w3.org/TR/wai-aria/states_and_properties#aria-expanded How do we refer to an element that isn't in our shadow root? :-\ hcarmona 2016/09/26 18:22:51 Only one screen reader supports this property and Show quoted text On 2016/09/07 22:38:42, michaelpg wrote: > shouldn't this reference what it expands? > > > If the element with the aria-expanded attribute controls the expansion of > another grouping container that is not 'owned by' the element, the author SHOULD > reference the container by using the aria-controls attribute. > > https://www.w3.org/TR/wai-aria/states_and_properties#aria-expanded > > How do we refer to an element that isn't in our shadow root? :-\ Only one screen reader supports this property and not all aria properties work well with shadow dom. (this is one of the ones) that doesn't work well. :-/ I've filed http://crbug.com/650334 to track adding the aria-controls attribute after speaking with dmazzoni@ about this.
12 </paper-icon-button>	12 </paper-icon-button>

13 </template>	13 </template>

14 <script src="cr_expand_button.js"></script>	14 <script src="cr_expand_button.js"></script>

15 </dom-module>	15 </dom-module>

OLD	NEW