Refactor some ResourceMessageReply usages.

chrome/renderer/pepper/pepper_extensions_common_host.h

Index: chrome/renderer/pepper/pepper_extensions_common_host.h
diff --git a/chrome/renderer/pepper/pepper_extensions_common_host.h b/chrome/renderer/pepper/pepper_extensions_common_host.h
index 5011897911599ebe7aba29be5933453b20ba4aeb..fbb880a4bafabe8d9a1ce6796007c272529afc35 100644
--- a/chrome/renderer/pepper/pepper_extensions_common_host.h
+++ b/chrome/renderer/pepper/pepper_extensions_common_host.h
@@ -63,7 +63,7 @@ class PepperExtensionsCommonHost : public ppapi::host::ResourceHost {
                  const base::ListValue& args);
 
   void OnResponseReceived(
-      scoped_ptr<ppapi::host::ReplyMessageContext> response_context,
+      ppapi::host::ReplyMessageContext reply_context,

[dmichael (off chromium), 2014/04/11 18:11:23]

const &?

[bbudge, 2014/04/11 20:41:19]

Done. However it requires making a copy so I can call set_result on the params.
I see precedents in the code but it seems a bit fishy.

[dmichael (off chromium), 2014/04/11 20:56:14]

Oh, right. I think either way is fine, then. Makes no practical difference.

[bbudge, 2014/04/11 22:46:05]

Went back to non-const as it's less surprising and less code.

       bool success,
       const base::ListValue& response,
       const std::string& error);