Refactor some ResourceMessageReply usages.

chrome/renderer/pepper/pepper_extensions_common_host.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_PEPPER_PEPPER_EXTENSIONS_COMMON_HOST_H_
 #define CHROME_RENDERER_PEPPER_PEPPER_EXTENSIONS_COMMON_HOST_H_
 
 #include <map>
 #include <string>
 
@@ skipping 45 matching lines @@
 
   int32_t OnPost(ppapi::host::HostMessageContext* context,
                  const std::string& request_name,
                  const base::ListValue& args);
 
   int32_t OnCall(ppapi::host::HostMessageContext* context,
                  const std::string& request_name,
                  const base::ListValue& args);
 
   void OnResponseReceived(
-      scoped_ptr<ppapi::host::ReplyMessageContext> response_context,
+      ppapi::host::ReplyMessageContext reply_context,

[dmichael (off chromium), 2014/04/11 18:11:23]

const &?

[bbudge, 2014/04/11 20:41:19]

Done. However it requires making a copy so I can call set_result on the params.
I see precedents in the code but it seems a bit fishy.

[dmichael (off chromium), 2014/04/11 20:56:14]

Oh, right. I think either way is fine, then. Makes no practical difference.

[bbudge, 2014/04/11 22:46:05]

Went back to non-const as it's less surprising and less code.

       bool success,
       const base::ListValue& response,
       const std::string& error);
 
   // Non-owning pointer.
   content::RendererPpapiHost* renderer_ppapi_host_;
   // Non-owning pointer.
   extensions::PepperRequestProxy* pepper_request_proxy_;
 
   base::WeakPtrFactory<PepperExtensionsCommonHost> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PepperExtensionsCommonHost);
 };
 
 #endif  // CHROME_RENDERER_PEPPER_PEPPER_EXTENSIONS_COMMON_HOST_H_