Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23187004: Do not include "wtf/Platform.h" directly (Closed)

Created:
7 years, 4 months ago by lgombos
Modified:
7 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, danakj, dglazkov+blink, Rik, adamk+blink_chromium.org, Stephen Chennney, jeez, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Do not include "wtf/Platform.h" directly. Follow the project coding style and include "config.h" instead of including "wtf/Platform.h". config.h includes "wtf/Platform.h". Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156609

Patch Set 1 #

Patch Set 2 : Remove an unrelated change. #

Patch Set 3 : Fix win build #

Patch Set 4 : Fix typo. #

Patch Set 5 : Fix Linux build #

Total comments: 3

Patch Set 6 : Add blank lines #

Patch Set 7 : Fix win_x64 build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -26 lines) Patch
M Source/core/platform/graphics/IntPoint.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/IntSize.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/chromium/VDMXParser.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/platform/graphics/chromium/VDMXParser.cpp View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M Source/web/InbandTextTrackPrivateImpl.cpp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/tests/CustomEventTest.cpp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/tests/ImageFilterBuilderTest.cpp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/tests/WebUnitTests.cpp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/Alignment.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/Assertions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/Atomics.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/ByteOrder.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/DataLog.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/PrintStream.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/ProcessID.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/ThreadSafeRefCounted.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/ThreadingPrimitives.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/TypeTraits.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/Uint8ClampedArray.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/UnusedParam.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/os-win32/inttypes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/os-win32/stdint.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/tests/RunAllTests.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lgombos
Fix for style.
7 years, 4 months ago (2013-08-21 08:07:08 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/23187004/diff/15001/Source/web/InbandTextTrackPrivateImpl.cpp File Source/web/InbandTextTrackPrivateImpl.cpp (right): https://codereview.chromium.org/23187004/diff/15001/Source/web/InbandTextTrackPrivateImpl.cpp#newcode32 Source/web/InbandTextTrackPrivateImpl.cpp:32: #include "InbandTextTrackPrivateImpl.h" There should be a blank line ...
7 years, 4 months ago (2013-08-21 17:14:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23187004/25001
7 years, 4 months ago (2013-08-22 03:18:26 UTC) #3
commit-bot: I haz the power
Change committed as 156542
7 years, 4 months ago (2013-08-22 04:56:39 UTC) #4
lgombos
On 2013/08/22 04:56:39, I haz the power (commit-bot) wrote: > Change committed as 156542 Got ...
7 years, 4 months ago (2013-08-22 18:49:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23187004/18001
7 years, 4 months ago (2013-08-22 23:21:10 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 01:38:48 UTC) #7
Message was sent while issue was closed. 
Change committed as 156609

Powered by Google App Engine
This is Rietveld 408576698