Issue 23003024: Revert r156542 "Do not include "wtf/Platform.h" directly. "

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23003024: Revert r156542 "Do not include "wtf/Platform.h" directly. " (Closed)

Created:
7 years, 4 months ago by jianli

Modified:
7 years, 4 months ago

Reviewers:
podivilov1

CC:
blink-reviews, jamesr, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, danakj, dglazkov+blink, Rik, adamk+blink_chromium.org, Stephen Chennney, jeez, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert r156542 "Do not include "wtf/Platform.h" directly. " This patch breaks win_x64_rel build: http://build.chromium.org/p/tryserver.chromium/builders/win_x64_rel/builds/32474 BUG=none TEST=none TBR=podivilov@google.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156568

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -13 lines)			Patch
M	Source/core/platform/graphics/IntPoint.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/platform/graphics/IntSize.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/VDMXParser.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/VDMXParser.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/web/InbandTextTrackPrivateImpl.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/web/tests/CustomEventTest.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/web/tests/ImageFilterBuilderTest.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/wtf/Alignment.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/wtf/Assertions.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/wtf/Atomics.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/wtf/ByteOrder.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/wtf/DataLog.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/wtf/PrintStream.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/wtf/ProcessID.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/wtf/ThreadSafeRefCounted.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/wtf/ThreadingPrimitives.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/wtf/TypeTraits.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/wtf/Uint8ClampedArray.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/wtf/UnusedParam.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/wtf/os-win32/inttypes.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/wtf/os-win32/stdint.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/wtf/tests/RunAllTests.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jianli

7 years, 4 months ago (2013-08-22 17:57:19 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r156568 (presubmit successful).

Expand Messages | Collapse Messages