Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Side by Side Diff: chrome/android/BUILD.gn

Issue 2318673003: Revert of GN(Android): Stop specifying depfile under outputs (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/android/rules.gni") 6 import("//build/config/android/rules.gni")
7 import("//build_overrides/v8.gni") 7 import("//build_overrides/v8.gni")
8 import("//chrome/android/chrome_public_apk_tmpl.gni") 8 import("//chrome/android/chrome_public_apk_tmpl.gni")
9 import("//chrome/common/features.gni") 9 import("//chrome/common/features.gni")
10 import("//chrome/version.gni") 10 import("//chrome/version.gni")
11 import("//testing/test.gni") 11 import("//testing/test.gni")
12 import("//third_party/icu/config.gni") 12 import("//third_party/icu/config.gni")
13 import("//third_party/protobuf/proto_library.gni") 13 import("//third_party/protobuf/proto_library.gni")
14 import("channel.gni") 14 import("channel.gni")
15 import("java_sources.gni") 15 import("java_sources.gni")
16 16
17 manifest_package = "org.chromium.chrome" 17 manifest_package = "org.chromium.chrome"
18 18
19 chrome_public_jinja_variables = default_chrome_public_jinja_variables + 19 chrome_public_jinja_variables = default_chrome_public_jinja_variables +
20 [ "manifest_package=$manifest_package" ] 20 [ "manifest_package=$manifest_package" ]
21 chrome_public_android_manifest =
22 "$target_gen_dir/chrome_public_apk/AndroidManifest.xml"
23 chrome_sync_shell_android_manifest =
24 "$target_gen_dir/chrome_sync_shell_apk/AndroidManifest.xml"
25 21
26 chrome_sync_shell_jinja_variables = 22 chrome_sync_shell_jinja_variables =
27 default_chrome_public_jinja_variables + 23 default_chrome_public_jinja_variables +
28 [ "manifest_package=org.chromium.chrome.sync_shell" ] 24 [ "manifest_package=org.chromium.chrome.sync_shell" ]
29 25
30 jinja_template("chrome_public_android_manifest") { 26 jinja_template("chrome_public_apk_manifest") {
31 input = "java/AndroidManifest.xml" 27 input = "java/AndroidManifest.xml"
32 output = chrome_public_android_manifest 28 output = "$root_gen_dir/chrome_public_apk_manifest/AndroidManifest.xml"
33 variables = chrome_public_jinja_variables 29 variables = chrome_public_jinja_variables
34 variables += [ 30 variables += [
35 "min_sdk_version=16", 31 "min_sdk_version=16",
36 "target_sdk_version=23", 32 "target_sdk_version=23",
37 ] 33 ]
38 } 34 }
39 35
40 jinja_template("chrome_sync_shell_android_manifest") { 36 jinja_template("chrome_sync_shell_apk_manifest") {
41 input = "java/AndroidManifest.xml" 37 input = "java/AndroidManifest.xml"
42 output = chrome_sync_shell_android_manifest 38 output = "$root_gen_dir/chrome_sync_shell_apk_manifest/AndroidManifest.xml"
43 variables = chrome_sync_shell_jinja_variables 39 variables = chrome_sync_shell_jinja_variables
44 variables += [ 40 variables += [
45 "min_sdk_version=16", 41 "min_sdk_version=16",
46 "target_sdk_version=22", 42 "target_sdk_version=22",
47 ] 43 ]
48 } 44 }
49 45
50 locale_pak_resources("chrome_locale_paks") { 46 locale_pak_resources("chrome_locale_paks") {
51 sources = [ 47 sources = [
52 "$root_out_dir/locales/am.pak", 48 "$root_out_dir/locales/am.pak",
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 "values-tr/android_chrome_strings.xml", 163 "values-tr/android_chrome_strings.xml",
168 "values-uk/android_chrome_strings.xml", 164 "values-uk/android_chrome_strings.xml",
169 "values-vi/android_chrome_strings.xml", 165 "values-vi/android_chrome_strings.xml",
170 "values-zh-rCN/android_chrome_strings.xml", 166 "values-zh-rCN/android_chrome_strings.xml",
171 "values-zh-rTW/android_chrome_strings.xml", 167 "values-zh-rTW/android_chrome_strings.xml",
172 ] 168 ]
173 } 169 }
174 170
175 android_library("chrome_java") { 171 android_library("chrome_java") {
176 deps = [ 172 deps = [
177 ":chrome_public_android_manifest", 173 ":chrome_public_apk_manifest",
178 ":chrome_public_apk_template_resources", 174 ":chrome_public_apk_template_resources",
179 "//base:base_java", 175 "//base:base_java",
180 "//chrome/android/webapk/libs/client:client_java", 176 "//chrome/android/webapk/libs/client:client_java",
181 "//chrome/android/webapk/libs/common:common_java", 177 "//chrome/android/webapk/libs/common:common_java",
182 "//chrome/android/webapk/libs/runtime_library:webapk_service_aidl_java", 178 "//chrome/android/webapk/libs/runtime_library:webapk_service_aidl_java",
183 "//components/safe_json/android:safe_json_java", 179 "//components/safe_json/android:safe_json_java",
184 "//components/spellcheck/browser/android:java", 180 "//components/spellcheck/browser/android:java",
185 "//components/variations/android:variations_java", 181 "//components/variations/android:variations_java",
186 "//components/web_contents_delegate_android:web_contents_delegate_android_ja va", 182 "//components/web_contents_delegate_android:web_contents_delegate_android_ja va",
187 "//components/web_restrictions:web_restrictions_java", 183 "//components/web_restrictions:web_restrictions_java",
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 "//chrome:content_setting_javagen", 223 "//chrome:content_setting_javagen",
228 "//chrome:content_settings_type_javagen", 224 "//chrome:content_settings_type_javagen",
229 "//chrome:data_use_ui_message_enum_javagen", 225 "//chrome:data_use_ui_message_enum_javagen",
230 "//chrome:signin_metrics_enum_javagen", 226 "//chrome:signin_metrics_enum_javagen",
231 ] 227 ]
232 228
233 # New versions of BuildConfig.java will be created when creating an apk. 229 # New versions of BuildConfig.java will be created when creating an apk.
234 jar_excluded_patterns = [ "*/BuildConfig.class" ] 230 jar_excluded_patterns = [ "*/BuildConfig.class" ]
235 231
236 # Manifest used for linting (determining unused resources). 232 # Manifest used for linting (determining unused resources).
237 android_manifest = chrome_public_android_manifest 233 android_manifest = get_target_outputs(":chrome_public_apk_manifest")
234 android_manifest = android_manifest[1]
238 235
239 # TODO(sievers): Split java code into components. Not everything 236 # TODO(sievers): Split java code into components. Not everything
240 # is really all that UI related here. 237 # is really all that UI related here.
241 if (android_java_ui) { 238 if (android_java_ui) {
242 # From java_sources.gni. 239 # From java_sources.gni.
243 java_files = chrome_java_sources 240 java_files = chrome_java_sources
244 241
245 srcjar_deps += [ 242 srcjar_deps += [
246 "//chrome:page_info_connection_type_javagen", 243 "//chrome:page_info_connection_type_javagen",
247 "//chrome:website_settings_action_javagen", 244 "//chrome:website_settings_action_javagen",
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 deps += [ 574 deps += [
578 ":chrome_java", 575 ":chrome_java",
579 ":chrome_public_apk_assets", 576 ":chrome_public_apk_assets",
580 ":chrome_public_apk_resources", 577 ":chrome_public_apk_resources",
581 "//base:base_java", 578 "//base:base_java",
582 ] 579 ]
583 } 580 }
584 } 581 }
585 582
586 chrome_public_apk_tmpl_shared("chrome_public_apk") { 583 chrome_public_apk_tmpl_shared("chrome_public_apk") {
587 android_manifest = chrome_public_android_manifest 584 android_manifest = get_target_outputs(":chrome_public_apk_manifest")
588 android_manifest_dep = ":chrome_public_android_manifest" 585 android_manifest = android_manifest[1]
586 android_manifest_dep = ":chrome_public_apk_manifest"
589 apk_name = "ChromePublic" 587 apk_name = "ChromePublic"
590 shared_libraries = [ ":chrome" ] 588 shared_libraries = [ ":chrome" ]
591 589
592 deps = [] 590 deps = []
593 } 591 }
594 592
595 chrome_public_apk_tmpl_shared("chrome_sync_shell_apk") { 593 chrome_public_apk_tmpl_shared("chrome_sync_shell_apk") {
596 testonly = true 594 testonly = true
597 android_manifest = chrome_sync_shell_android_manifest 595 android_manifest = get_target_outputs(":chrome_sync_shell_apk_manifest")
598 android_manifest_dep = ":chrome_sync_shell_android_manifest" 596 android_manifest = android_manifest[1]
597 android_manifest_dep = ":chrome_sync_shell_apk_manifest"
599 apk_name = "ChromeSyncShell" 598 apk_name = "ChromeSyncShell"
600 shared_libraries = [ ":chrome_sync_shell" ] 599 shared_libraries = [ ":chrome_sync_shell" ]
601 600
602 deps = [ 601 deps = [
603 ":chrome_sync_shell_apk_template_resources", 602 ":chrome_sync_shell_apk_template_resources",
604 603
605 # This exists here because com.google.protobuf.nano is needed in tests, 604 # This exists here because com.google.protobuf.nano is needed in tests,
606 # but that code is stripped out via proguard. Adding this deps adds 605 # but that code is stripped out via proguard. Adding this deps adds
607 # usages and prevents removal of the proto code. 606 # usages and prevents removal of the proto code.
608 "//components/sync:test_support_sync_proto_java", 607 "//components/sync:test_support_sync_proto_java",
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 instrumentation_test_apk("chrome_sync_shell_test_apk") { 672 instrumentation_test_apk("chrome_sync_shell_test_apk") {
674 apk_name = "ChromeSyncShellTest" 673 apk_name = "ChromeSyncShellTest"
675 apk_under_test = ":chrome_sync_shell_apk" 674 apk_under_test = ":chrome_sync_shell_apk"
676 android_manifest = chrome_sync_shell_test_apk_manifest 675 android_manifest = chrome_sync_shell_test_apk_manifest
677 android_manifest_dep = ":chrome_sync_shell_test_apk_manifest" 676 android_manifest_dep = ":chrome_sync_shell_test_apk_manifest"
678 deps = [ 677 deps = [
679 ":chrome_sync_shell_test_apk_java", 678 ":chrome_sync_shell_test_apk_java",
680 ] 679 ]
681 proguard_enabled = !is_java_debug 680 proguard_enabled = !is_java_debug
682 } 681 }
OLDNEW
« no previous file with comments | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698