MD History: truncate title to 300 chars in C++ instead of JS

MD History: truncate title to 300 chars in C++ instead of JS

Potentially communicates less data over IPC, lets the UI do less work.

R=tsergeant@chromium.org
BUG=621347, 629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c9a774fad351d0f7a648af4be7c7ad82e06b7a62
Cr-Commit-Position: refs/heads/master@{#416961}

[Dan Beam, 2016-09-06 18:58:34]

Description was changed from

==========
MD History: truncate title to 300 chars in C++ instead of JS

Potentially communicates less data over IPC, less the UI do less work.

R=tsergeant@chromium.org
BUG=none
==========

to

==========
MD History: truncate title to 300 chars in C++ instead of JS

Potentially communicates less data over IPC, less the UI do less work.

R=tsergeant@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-09-06 19:01:08]

Description was changed from

==========
MD History: truncate title to 300 chars in C++ instead of JS

Potentially communicates less data over IPC, less the UI do less work.

R=tsergeant@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: truncate title to 300 chars in C++ instead of JS

Potentially communicates less data over IPC, lets the UI do less work.

R=tsergeant@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-09-06 19:01:52]

Description was changed from

==========
MD History: truncate title to 300 chars in C++ instead of JS

Potentially communicates less data over IPC, lets the UI do less work.

R=tsergeant@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: truncate title to 300 chars in C++ instead of JS

Potentially communicates less data over IPC, lets the UI do less work.

R=tsergeant@chromium.org
BUG=621347,629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-09-06 19:01:58]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 19:02:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 19:45:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 19:45:21]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Dan Beam, 2016-09-06 21:49:12]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 21:49:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 22:17:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 22:17:24]

Dry run: Exceeded global retry quota

[Dan Beam, 2016-09-06 22:37:30]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 22:38:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-09-06 23:03:21]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 23:03:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-09-06 23:28:25]

lgtm

https://codereview.chromium.org/2318643003/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/browsing_history_handler.cc (right):

https://codereview.chromium.org/2318643003/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/browsing_history_handler.cc:16: #include
"base/logging.h"
Nit: Can this be removed?

[Dan Beam, 2016-09-06 23:30:22]

https://codereview.chromium.org/2318643003/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/browsing_history_handler.cc (right):

https://codereview.chromium.org/2318643003/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/browsing_history_handler.cc:16: #include
"base/logging.h"
On 2016/09/06 23:28:25, tsergeant wrote:
> Nit: Can this be removed?

it could but this file uses LOG() stuff

[commit-bot: I haz the power, 2016-09-06 23:50:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 23:50:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-09-07 01:45:18]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 01:45:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 02:15:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 02:15:29]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Dan Beam, 2016-09-07 04:44:04]

dbeam@chromium.org changed reviewers:
+ sky@chromium.org

[Dan Beam, 2016-09-07 04:44:04]

+sky@ for chrome/browser/ui/find_bar, chrome/browser/history

[Dan Beam, 2016-09-07 04:44:28]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 04:44:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 05:41:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 05:41:30]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-07 15:14:54]

LGTM

[Dan Beam, 2016-09-07 16:32:03]

On 2016/09/07 15:14:54, sky wrote:
> LGTM

thanks for the review, y'all!

[Dan Beam, 2016-09-07 16:32:08]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-09-07 16:32:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2318643003/#ps100001
(title: "more !android")

[commit-bot: I haz the power, 2016-09-07 16:32:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 16:39:26]

Description was changed from

==========
MD History: truncate title to 300 chars in C++ instead of JS

Potentially communicates less data over IPC, lets the UI do less work.

R=tsergeant@chromium.org
BUG=621347,629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: truncate title to 300 chars in C++ instead of JS

Potentially communicates less data over IPC, lets the UI do less work.

R=tsergeant@chromium.org
BUG=621347,629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-07 16:39:28]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-07 16:41:32]

Description was changed from

==========
MD History: truncate title to 300 chars in C++ instead of JS

Potentially communicates less data over IPC, lets the UI do less work.

R=tsergeant@chromium.org
BUG=621347,629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: truncate title to 300 chars in C++ instead of JS

Potentially communicates less data over IPC, lets the UI do less work.

R=tsergeant@chromium.org
BUG=621347,629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c9a774fad351d0f7a648af4be7c7ad82e06b7a62
Cr-Commit-Position: refs/heads/master@{#416961}
==========

[commit-bot: I haz the power, 2016-09-07 16:41:33]

Patchset 6 (id:??) landed as
https://crrev.com/c9a774fad351d0f7a648af4be7c7ad82e06b7a62
Cr-Commit-Position: refs/heads/master@{#416961}