MD History: truncate title to 300 chars in C++ instead of JS

chrome/browser/ui/webui/browsing_history_handler_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/browsing_history_handler.h"
 
 #include <stdint.h>
 #include <memory>
 #include <set>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/values.h"
 #include "chrome/browser/history/web_history_service_factory.h"
 #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"
 #include "chrome/browser/signin/fake_signin_manager_builder.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/sync/profile_sync_test_util.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/browser_sync/browser/test_profile_sync_service.h"
 #include "components/history/core/test/fake_web_history_service.h"
 #include "components/signin/core/browser/fake_profile_oauth2_token_service.h"
 #include "components/signin/core/browser/fake_signin_manager.h"
 #include "components/sync/base/model_type.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_web_ui.h"
 #include "net/http/http_status_code.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
+#if !defined(OS_ANDROID)
+#include "chrome/browser/ui/webui/md_history_ui.h"
+#endif
+
 namespace {
 
 struct TestResult {
   std::string url;
   int64_t hour_offset;  // Visit time in hours past the baseline time.
 };
 
 // Duplicates on the same day in the local timezone are removed, so set a
 // baseline time in local time.
 const base::Time baseline_time = base::Time::UnixEpoch().LocalMidnight();
@@ skipping 47 matching lines @@
  private:
   bool sync_active_;
 };
 
 class BrowsingHistoryHandlerWithWebUIForTesting
     : public BrowsingHistoryHandler {
  public:
   explicit BrowsingHistoryHandlerWithWebUIForTesting(content::WebUI* web_ui) {
     set_web_ui(web_ui);
   }
+  using BrowsingHistoryHandler::QueryComplete;
 };
 
 }  // namespace
 
 class BrowsingHistoryHandlerTest : public ::testing::Test {
  public:
   void SetUp() override {
     TestingProfile::Builder builder;
     builder.AddTestingFactory(ProfileOAuth2TokenServiceFactory::GetInstance(),
                               &BuildFakeProfileOAuth2TokenService);
     builder.AddTestingFactory(SigninManagerFactory::GetInstance(),
                               &BuildFakeSigninManagerBase);
     builder.AddTestingFactory(ProfileSyncServiceFactory::GetInstance(),
                               &BuildFakeSyncService);
     builder.AddTestingFactory(WebHistoryServiceFactory::GetInstance(),
                               &BuildFakeWebHistoryService);
     profile_ = builder.Build();
+    profile_->CreateBookmarkModel(false);
 
     sync_service_ = static_cast<TestSyncService*>(
         ProfileSyncServiceFactory::GetForProfile(profile_.get()));
     web_history_service_ = static_cast<history::FakeWebHistoryService*>(
         WebHistoryServiceFactory::GetForProfile(profile_.get()));
 
     web_contents_.reset(content::WebContents::Create(
         content::WebContents::CreateParams(profile_.get())));
     web_ui_.reset(new content::TestWebUI);
     web_ui_->set_web_contents(web_contents_.get());
@@ skipping 168 matching lines @@
     BrowsingHistoryHandlerWithWebUIForTesting handler(web_ui());
     handler.RegisterMessages();
 
     web_history_service()->ExpireHistoryBetween(std::set<GURL>(), base::Time(),
                                                 base::Time::Max(), callback);
 
     // No additional WebUI calls were made.
     EXPECT_EQ(2U, web_ui()->call_data().size());
   }
 }
+
+#if !defined(OS_ANDROID)
+TEST_F(BrowsingHistoryHandlerTest, MdTruncatesTitles) {
+  MdHistoryUI::SetEnabledForTesting(true);
+
+  history::URLResult long_result(
+      GURL("http://looooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"
+      "oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"
+      "oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"
+      "oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"
+      "oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"
+      "oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo"
+      "ngurlislong.com"), base::Time());
+  ASSERT_GT(long_result.url().spec().size(), 300u);
+
+  history::QueryResults results;
+  results.AppendURLBySwapping(&long_result);
+
+  BrowsingHistoryHandlerWithWebUIForTesting handler(web_ui());
+  web_ui()->ClearTrackedCalls();
+
+  handler.QueryComplete(base::string16(), history::QueryOptions(), &results);
+  ASSERT_FALSE(web_ui()->call_data().empty());
+
+  const base::ListValue* arg2;
+  ASSERT_TRUE(web_ui()->call_data().front()->arg2()->GetAsList(&arg2));
+
+  const base::DictionaryValue* first_entry;
+  ASSERT_TRUE(arg2->GetDictionary(0, &first_entry));
+
+  base::string16 title;
+  ASSERT_TRUE(first_entry->GetString("title", &title));
+
+  ASSERT_EQ(0u, title.find(base::ASCIIToUTF16("http://loooo")));
+  EXPECT_EQ(300u, title.size());
+}
+#endif