Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2318553002: [arm] Implement barriers on ARMv6 using CP15. (Closed)

Created:
4 years, 3 months ago by jbramley
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Implement barriers on ARMv6 using CP15. ARMv6 has the same basic barriers as ARMv7+, but they are accessed using the CP15 coprocessor. This patch allows the assembler to select the appropriate instruction. This also fixes TurboFan's atomic loads and stores for ARMv6 platforms. BUG= Committed: https://crrev.com/1001ddf20f0b8f122207ef76566155518b4248ba Cr-Commit-Position: refs/heads/master@{#39203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -8 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +24 lines, -3 lines 0 comments Download
M src/arm/disasm-arm.cc View 3 chunks +42 lines, -1 line 0 comments Download
M src/arm/simulator-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 3 chunks +37 lines, -1 line 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +25 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
4 years, 3 months ago (2016-09-06 10:23:17 UTC) #2
epertoso
lgtm Thanks.
4 years, 3 months ago (2016-09-06 11:02:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318553002/1
4 years, 3 months ago (2016-09-06 11:03:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 11:30:02 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 11:30:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1001ddf20f0b8f122207ef76566155518b4248ba
Cr-Commit-Position: refs/heads/master@{#39203}

Powered by Google App Engine
This is Rietveld 408576698