[Password Generation] Use signatures for form matching

components/autofill/core/common/form_field_data.cc

Index: components/autofill/core/common/form_field_data.cc
diff --git a/components/autofill/core/common/form_field_data.cc b/components/autofill/core/common/form_field_data.cc
index 49447aba6d1476c3012f85d6aabe57296804c7cd..6e19116ad9a9e0431bc87c2451d4e38c7f8a494d 100644
--- a/components/autofill/core/common/form_field_data.cc
+++ b/components/autofill/core/common/form_field_data.cc
@@ -7,6 +7,7 @@
 #include "base/pickle.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "components/autofill/core/common/autofill_util.h"

[Nico, 2016/09/09 16:29:23]

fwiw we generally discourage "util" files since they end up as dumping grounds.
Can you think of a more specific name?

 
 namespace autofill {
 
@@ -350,27 +351,4 @@ std::ostream& operator<<(std::ostream& os, const FormFieldData& field) {
             << field.properties_mask;
 }
 
-bool IsCheckable(const FormFieldData::CheckStatus& check_status) {
-  return check_status != FormFieldData::CheckStatus::NOT_CHECKABLE;
-}
-
-bool IsChecked(const FormFieldData::CheckStatus& check_status) {
-  return check_status == FormFieldData::CheckStatus::CHECKED;
-}
-
-void SetCheckStatus(FormFieldData* form_field_data,
-                    bool isCheckable,
-                    bool isChecked) {
-  if (isChecked) {
-    form_field_data->check_status = FormFieldData::CheckStatus::CHECKED;
-  } else {
-    if (isCheckable) {
-      form_field_data->check_status =
-          FormFieldData::CheckStatus::CHECKABLE_BUT_UNCHECKED;
-    } else {
-      form_field_data->check_status = FormFieldData::CheckStatus::NOT_CHECKABLE;
-    }
-  }
-}
-
 }  // namespace autofill