Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2318353002: Remove ignored "force" parameter from bot_update. (Closed)

Created:
4 years, 3 months ago by iannucci
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ignored "force" parameter from bot_update. It's already ignored by the bot_update implementation, so this is an expectations-only change. R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org BUG=643885 Committed: https://crrev.com/b8c78bcc917cd7d04fb0fce40490838deebd51d3 Cr-Commit-Position: refs/heads/master@{#417251}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M infra/recipes/blink_downstream.py View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_fail.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_pass.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json View 2 chunks +0 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json View 2 chunks +0 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json View 2 chunks +0 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json View 2 chunks +0 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/minimal_pass_continues.json View 2 chunks +0 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/too_many_failures_for_retcode.json View 2 chunks +0 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/webkit_tests_interrupted.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json View 1 chunk +0 lines, -1 line 0 comments Download
M infra/recipes/canary.py View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/canary.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
iannucci
4 years, 3 months ago (2016-09-07 20:24:52 UTC) #1
martiniss
https://codereview.chromium.org/2318353002/diff/1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json File infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json (right): https://codereview.chromium.org/2318353002/diff/1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json#newcode244 infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json:244: "--enable-usb-reset" This line doesn't look related to your change....?
4 years, 3 months ago (2016-09-07 21:15:32 UTC) #2
iannucci
On 2016/09/07 at 21:15:32, martiniss wrote: > https://codereview.chromium.org/2318353002/diff/1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json > File infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json (right): > > https://codereview.chromium.org/2318353002/diff/1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json#newcode244 ...
4 years, 3 months ago (2016-09-07 21:40:53 UTC) #3
iannucci
On 2016/09/07 at 21:40:53, iannucci wrote: > On 2016/09/07 at 21:15:32, martiniss wrote: > > ...
4 years, 3 months ago (2016-09-08 09:58:45 UTC) #6
tandrii(chromium)
lgtm
4 years, 3 months ago (2016-09-08 11:02:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318353002/20001
4 years, 3 months ago (2016-09-08 11:03:12 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 11:07:32 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 11:08:49 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8c78bcc917cd7d04fb0fce40490838deebd51d3
Cr-Commit-Position: refs/heads/master@{#417251}

Powered by Google App Engine
This is Rietveld 408576698