infra/recipes/blink_downstream.py - Issue 2318353002: Remove ignored "force" parameter from bot_update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/recipes/blink_downstream.py

Issue 2318353002: Remove ignored "force" parameter from bot_update. (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/recipes/blink_downstream.py

diff --git a/infra/recipes/blink_downstream.py b/infra/recipes/blink_downstream.py

index 07ec622b623f00d0d6a316d8387a37d40d3e11ee..5f5258fd58cdc66ea3057916c6c02608020ccf80 100644

--- a/infra/recipes/blink_downstream.py

+++ b/infra/recipes/blink_downstream.py

@@ -141,7 +141,7 @@ def RunSteps(api):

with api.step.context(context):

# TODO(phajdan.jr): remove redundant **context below once we fix things

# to behave the same without it.

- step_result = api.bot_update.ensure_checkout(force=True, **context)

+ step_result = api.bot_update.ensure_checkout(**context)

api.chromium.ensure_goma()

@@ -165,7 +165,7 @@ def RunSteps(api):

# Update without changing got_revision. The first sync is the revision

# that is tested. The second is just for comparison. Setting got_revision

# again confuses the waterfall's console view.

- api.bot_update.ensure_checkout(force=True, update_presentation=False)

+ api.bot_update.ensure_checkout(update_presentation=False)

api.chromium_tests.run_mb_and_compile(

['blink_tests'], [],

« no previous file with comments | « no previous file | infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_fail.json » ('j') | no next file with comments »