Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231833005: Refactor v8_types.v8_value_to_local_cpp_value for clarity and to make Promises easier to implement (Closed)

Created:
6 years, 8 months ago by Nils Barth (inactive)
Modified:
6 years, 8 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, yhirano
Visibility:
Public.

Description

Refactor v8_types.v8_value_to_local_cpp_value for clarity and to make Promises easier to implement Noticed this cleanup, which will also make reuse easier. Support for CL: API functions returning Promises should not throw exceptions. https://codereview.chromium.org/232563003/ R=haraken BUG=359386 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171262

Patch Set 1 #

Patch Set 2 : Naming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
Quick cleanup, which should help Yutaka.
6 years, 8 months ago (2014-04-10 07:55:54 UTC) #1
haraken
LGTM.
6 years, 8 months ago (2014-04-10 07:58:16 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 8 months ago (2014-04-10 07:59:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/231833005/20001
6 years, 8 months ago (2014-04-10 07:59:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 08:27:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-10 08:27:41 UTC) #6
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 8 months ago (2014-04-10 09:48:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/231833005/20001
6 years, 8 months ago (2014-04-10 09:48:36 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 10:53:12 UTC) #9
Message was sent while issue was closed. 
Change committed as 171262

Powered by Google App Engine
This is Rietveld 408576698