Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2318283002: DCHECK that the document url is valid in HTMLPreloadScanner (Closed)

Created:
4 years, 3 months ago by Charlie Harrison
Modified:
4 years, 3 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, Yoav Weiss, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DCHECK that the document url is valid in HTMLPreloadScanner This patch asserts that the document url passed into the scanner is valid. This fixes a fuzzer issue where the fuzzer was passing in an empty (invalid) url. BUG=644667 Committed: https://crrev.com/42754d4bc93465269b460b5912a3d7f30549e53c Cr-Commit-Position: refs/heads/master@{#417092}

Patch Set 1 #

Patch Set 2 : fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParserTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerFuzzer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Charlie Harrison
kouhei@, PTAL?
4 years, 3 months ago (2016-09-07 20:59:03 UTC) #6
kouhei (in TOK)
lgtm
4 years, 3 months ago (2016-09-07 22:16:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318283002/20001
4 years, 3 months ago (2016-09-07 22:16:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 22:22:23 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/42754d4bc93465269b460b5912a3d7f30549e53c Cr-Commit-Position: refs/heads/master@{#417092}
4 years, 3 months ago (2016-09-07 22:24:25 UTC) #14
Charlie Harrison
4 years, 3 months ago (2016-09-07 22:55:17 UTC) #15
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698