third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp - Issue 2318283002: DCHECK that the document url is valid in HTMLPreloadScanner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

Issue 2318283002: DCHECK that the document url is valid in HTMLPreloadScanner (Closed)

Patch Set: fix unit test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

index 509ada508bc91f09185715b23e193a561e30e1dc..d46092c33e8a4fbd48ecd06f295b20dadaba6fb4 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

@@ -503,8 +503,9 @@ TokenPreloadScanner::TokenPreloadScanner(const KURL& documentURL, std::unique_pt

, m_mediaValues(MediaValuesCached::create(mediaValuesCachedData))

, m_didRewind(false)

{

- ASSERT(m_documentParameters.get());

- ASSERT(m_mediaValues.get());

+ DCHECK(m_documentParameters.get());

+ DCHECK(m_mediaValues.get());

+ DCHECK(documentURL.isValid());

m_cssScanner.setReferrerPolicy(m_documentParameters->referrerPolicy);

}