Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/dartium/test.py

Issue 2318153002: Remove --win-ninja option from dartium buildbot scripts (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dartium/buildbot_annotated_steps.py ('k') | tools/dartium/upload_steps.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dartium/test.py
diff --git a/tools/dartium/test.py b/tools/dartium/test.py
index 0f16b41086d2e5b268746765fb8f20dd4e7fd1b0..ca48152f0ff460920da67a8d937b3213e64ede2c 100755
--- a/tools/dartium/test.py
+++ b/tools/dartium/test.py
@@ -112,9 +112,6 @@ def main():
default=None,
action='store', type='string',
help='Test filter for core tests')
- parser.add_option('--win-ninja-build', action='store_true',
- default=False, dest='is_win_ninja',
- help='We are on windows and use ninja for building.')
(options, args) = parser.parse_args()
mode = options.mode
@@ -158,8 +155,6 @@ def main():
show_results = '--no-show-results'
host_os = utils.guessOS()
- if options.is_win_ninja:
- host_os = 'win-ninja'
build_root, drt_path, dartium_path, dart_path = {
'mac': (
'out',
@@ -169,7 +164,6 @@ def main():
),
'linux': ('out', 'content_shell', 'chrome', 'dart'),
'win': ('out', 'content_shell.exe', 'chrome.exe', 'dart.exe'),
- 'win-ninja': ('out', 'content_shell.exe', 'chrome.exe', 'dart.exe'),
}[host_os]
build_dir = os.path.join(srcpath, build_root, mode)
« no previous file with comments | « tools/dartium/buildbot_annotated_steps.py ('k') | tools/dartium/upload_steps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698