Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: tools/dartium/buildbot_annotated_steps.py

Issue 2318153002: Remove --win-ninja option from dartium buildbot scripts (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dartium/archive.py ('k') | tools/dartium/test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dartium/buildbot_annotated_steps.py
diff --git a/tools/dartium/buildbot_annotated_steps.py b/tools/dartium/buildbot_annotated_steps.py
index c568b8e6223e9dd1a4695b64f907cd0212078e1c..0f69c1f88ff355d8d04db85c770d1a128ccf2e2f 100755
--- a/tools/dartium/buildbot_annotated_steps.py
+++ b/tools/dartium/buildbot_annotated_steps.py
@@ -28,8 +28,7 @@ DART_PATH = os.path.join(SRC_PATH, 'dart')
# We limit testing on drt since it takes a long time to run.
DRT_FILTER = 'html'
-def RunDartTests(mode, component, suite, arch, checked, test_filter=None,
- is_win_ninja=False):
+def RunDartTests(mode, component, suite, arch, checked, test_filter=None):
"""Runs tests using the Dart test.py or the layout test runner.
"""
cmd = []
@@ -46,9 +45,6 @@ def RunDartTests(mode, component, suite, arch, checked, test_filter=None,
cmd.append('--' + checked)
cmd.append('--no-show-results')
- if is_win_ninja:
- cmd.append('--win-ninja-build')
-
if test_filter:
cmd.append('--test-filter=' + test_filter)
@@ -67,7 +63,7 @@ def Test(info, component, suite, checked, test_filter=None):
'layout-test-results')
shutil.rmtree(layout_test_results_dir, ignore_errors=True)
status = RunDartTests(info.mode, component, suite, info.arch, checked,
- test_filter=test_filter, is_win_ninja=info.is_win_ninja)
+ test_filter=test_filter)
# Archive test failures
if suite == 'layout' and status != 0:
upload_steps.UploadDartTestsResults(layout_test_results_dir,
« no previous file with comments | « tools/dartium/archive.py ('k') | tools/dartium/test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698