Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2318153002: Remove --win-ninja option from dartium buildbot scripts (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove --win-ninja option from dartium buildbot scripts This option no longer does anything. Script is currently broken because of it. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/f92b270d402416768cb8ada761fe5dd9126ebd5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M tools/dartium/archive.py View 2 chunks +2 lines, -5 lines 0 comments Download
M tools/dartium/buildbot_annotated_steps.py View 3 chunks +2 lines, -6 lines 0 comments Download
M tools/dartium/test.py View 3 chunks +0 lines, -6 lines 0 comments Download
M tools/dartium/upload_steps.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
4 years, 3 months ago (2016-09-07 14:40:28 UTC) #2
kustermann
lgtm
4 years, 3 months ago (2016-09-07 14:49:17 UTC) #3
Bill Hesse
4 years, 3 months ago (2016-09-07 15:02:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f92b270d402416768cb8ada761fe5dd9126ebd5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698