c/browser, c/common, components M-N: Change ScopedTempDir::path() to GetPath()

components/nacl/browser/pnacl_translation_cache_unittest.cc

Index: components/nacl/browser/pnacl_translation_cache_unittest.cc
diff --git a/components/nacl/browser/pnacl_translation_cache_unittest.cc b/components/nacl/browser/pnacl_translation_cache_unittest.cc
index 18551f0a069d25ab960f4d14a4796063a09f54a3..dfc3bdefc6372d99051ff342a2c6b587ee2fa03b 100644
--- a/components/nacl/browser/pnacl_translation_cache_unittest.cc
+++ b/components/nacl/browser/pnacl_translation_cache_unittest.cc
@@ -60,7 +60,7 @@ void PnaclTranslationCacheTest::InitBackend(bool in_mem) {
   }
   // Use the private init method so we can control the size
   int rv = cache_->Init(in_mem ? net::MEMORY_CACHE : net::PNACL_CACHE,
-                        temp_dir_.path(),
+                        in_mem ? base::FilePath() : temp_dir_.GetPath(),

[vabr (Chromium), 2016/09/14 13:32:41]

Before: ScopedTempDir needed to trust InitBackend and its callees that the path
is not used if empty.
Now: InitBackend needs to trust cache_ that the cache_ won't use the path if
empty.

In other words, there is still potential for misuse, but at least the scope is
limited.

[Mark Seaborn, 2016/09/14 18:27:26]

Can you put that note in the commit message, please, plus the note that it's the
only non-mechanical change?  LGTM otherwise.

[vabr (Chromium), 2016/09/14 20:14:39]

I made an attempt at adding this to the CL. There were two places in this CL
with a similar comment (but only one reviewed by you), so I added both.

                         in_mem ? kMaxMemCacheSize : kTestDiskCacheSize,
                         init_cb.callback());
   if (in_mem)