c/browser, c/common, components M-N: Change ScopedTempDir::path() to GetPath()

components/nacl/browser/pnacl_translation_cache_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/nacl/browser/pnacl_translation_cache.h"
 
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
@@ skipping 42 matching lines @@
   base::ScopedTempDir temp_dir_;
 };
 
 void PnaclTranslationCacheTest::InitBackend(bool in_mem) {
   net::TestCompletionCallback init_cb;
   if (!in_mem) {
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
   }
   // Use the private init method so we can control the size
   int rv = cache_->Init(in_mem ? net::MEMORY_CACHE : net::PNACL_CACHE,
-                        temp_dir_.path(),
+                        in_mem ? base::FilePath() : temp_dir_.GetPath(),

[vabr (Chromium), 2016/09/14 13:32:41]

Before: ScopedTempDir needed to trust InitBackend and its callees that the path
is not used if empty.
Now: InitBackend needs to trust cache_ that the cache_ won't use the path if
empty.

In other words, there is still potential for misuse, but at least the scope is
limited.

[Mark Seaborn, 2016/09/14 18:27:26]

Can you put that note in the commit message, please, plus the note that it's the
only non-mechanical change?  LGTM otherwise.

[vabr (Chromium), 2016/09/14 20:14:39]

I made an attempt at adding this to the CL. There were two places in this CL
with a similar comment (but only one reviewed by you), so I added both.

                         in_mem ? kMaxMemCacheSize : kTestDiskCacheSize,
                         init_cb.callback());
   if (in_mem)
     ASSERT_EQ(net::OK, rv);
   ASSERT_EQ(net::OK, init_cb.GetResult(rv));
   ASSERT_EQ(0, cache_->Size());
 }
 
 void PnaclTranslationCacheTest::StoreNexe(const std::string& key,
                                           const std::string& nexe) {
@@ skipping 221 matching lines @@
   StoreNexe(test_key, test_store_val);
   TestNexeCallback load_cb;
   std::string nexe;
   cache_->GetNexe(test_key + "a", load_cb.callback());
   int rv;
   scoped_refptr<net::DrainableIOBuffer> buf(load_cb.GetResult(&rv));
   EXPECT_EQ(net::ERR_FAILED, rv);
 }
 
 }  // namespace pnacl