Add CSS property priority for CSS animation affecting properties

Add CSS property priority for CSS animation affecting properties

This change adds a separate priority for CSS properties that affect
running animations. This is in preparation for enabling animation
of custom properties.

There is no meaningful change in behaviour made by this patch.

The reordering of CSSPropertyIDs has revealed a bug in CSS
property/SVG presentation attribute animation collision where the
"winner" is based on hash iteration ordering rather than
meaningful rules. This should not impact users in any significant
way as targeting SVG properties in Web Animations is still behind
the experimental flag.

The call to applyMatchedProperties<HighPriorityProperty>() in
styleForPage() has been deliberately left alone.
Animation properties are not used by callers of styleForPage()
and animation effects were not applied previously.

BUG=644148
Committed: https://crrev.com/6d47d44ba4c0ba026223adb94d7f236fbc5efa22
Cr-Commit-Position: refs/heads/master@{#431706}

[alancutter (OOO until 2018), 2016-10-21 05:15:07]

Description was changed from

==========
[WIP] Add CSS property priority for CSS animation affecting properties

BUG=
==========

to

==========
Add CSS property priority for CSS animation affecting properties

This change adds a separate priority for CSS properties that affect
running animations. This is in preparation for enabling animation
of custom properties.

There is no change in behaviour made by this patch.

BUG=644148
==========

[alancutter (OOO until 2018), 2016-10-21 05:15:07]

alancutter@chromium.org changed reviewers:
+ timloh@chromium.org

[alancutter (OOO until 2018), 2016-10-21 05:18:14]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 05:18:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2016-10-21 05:42:55]

https://codereview.chromium.org/2317903003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/CSSPropertyPriority.h (right):

https://codereview.chromium.org/2317903003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/CSSPropertyPriority.h:66:
CSSPropertyTransitionProperty == CSSPropertyTransitionTimingFunction - 1,
This assert seems pretty random and not useful, I wouldn't add it :/

https://codereview.chromium.org/2317903003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp (right):

https://codereview.chromium.org/2317903003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:1758: state,
matchResult.allRules(), false, applyInheritedOnly);
Don't we need to call this twice, once for not important and once for important?

[commit-bot: I haz the power, 2016-10-21 07:06:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 07:06:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2016-10-24 04:08:17]

Description was changed from

==========
Add CSS property priority for CSS animation affecting properties

This change adds a separate priority for CSS properties that affect
running animations. This is in preparation for enabling animation
of custom properties.

There is no change in behaviour made by this patch.

BUG=644148
==========

to

==========
Add CSS property priority for CSS animation affecting properties

This change adds a separate priority for CSS properties that affect
running animations. This is in preparation for enabling animation
of custom properties.

There is no meaningful change in behaviour made by this patch.

The reordering of CSSPropertyIDs has revealed a bug in CSS
property/SVG presentation attribute animation collision where the
"winner" is based on hash iteration ordering rather than
meaningful rules. This should not impact users in any significant
way as targeting SVG properties in Web Animations is still behind
the experimental flag.

BUG=644148
==========

[alancutter (OOO until 2018), 2016-10-24 04:08:27]

https://codereview.chromium.org/2317903003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/CSSPropertyPriority.h (right):

https://codereview.chromium.org/2317903003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/CSSPropertyPriority.h:66:
CSSPropertyTransitionProperty == CSSPropertyTransitionTimingFunction - 1,
On 2016/10/21 at 05:42:55, Timothy Loh wrote:
> This assert seems pretty random and not useful, I wouldn't add it :/

Agreed, it was copying the logic of the assertion below. Changed it to be a + 1
test instead of - 1.

https://codereview.chromium.org/2317903003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp (right):

https://codereview.chromium.org/2317903003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:1758: state,
matchResult.allRules(), false, applyInheritedOnly);
On 2016/10/21 at 05:42:55, Timothy Loh wrote:
> Don't we need to call this twice, once for not important and once for
important?

Oops, yes.

[alancutter (OOO until 2018), 2016-10-24 04:08:31]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 04:08:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alancutter (OOO until 2018), 2016-10-24 05:14:44]

Description was changed from

==========
Add CSS property priority for CSS animation affecting properties

This change adds a separate priority for CSS properties that affect
running animations. This is in preparation for enabling animation
of custom properties.

There is no meaningful change in behaviour made by this patch.

The reordering of CSSPropertyIDs has revealed a bug in CSS
property/SVG presentation attribute animation collision where the
"winner" is based on hash iteration ordering rather than
meaningful rules. This should not impact users in any significant
way as targeting SVG properties in Web Animations is still behind
the experimental flag.

BUG=644148
==========

to

==========
Add CSS property priority for CSS animation affecting properties

This change adds a separate priority for CSS properties that affect
running animations. This is in preparation for enabling animation
of custom properties.

There is no meaningful change in behaviour made by this patch.

The reordering of CSSPropertyIDs has revealed a bug in CSS
property/SVG presentation attribute animation collision where the
"winner" is based on hash iteration ordering rather than
meaningful rules. This should not impact users in any significant
way as targeting SVG properties in Web Animations is still behind
the experimental flag.

The call to applyMatchedProperties<HighPriorityProperties>() in
styleForPage() has been deliberately left alone.
Animation properties are not used by callers of styleForPage()
and animation effects were not applied previously.

BUG=644148
==========

[alancutter (OOO until 2018), 2016-10-24 05:14:59]

Description was changed from

==========
Add CSS property priority for CSS animation affecting properties

This change adds a separate priority for CSS properties that affect
running animations. This is in preparation for enabling animation
of custom properties.

There is no meaningful change in behaviour made by this patch.

The reordering of CSSPropertyIDs has revealed a bug in CSS
property/SVG presentation attribute animation collision where the
"winner" is based on hash iteration ordering rather than
meaningful rules. This should not impact users in any significant
way as targeting SVG properties in Web Animations is still behind
the experimental flag.

The call to applyMatchedProperties<HighPriorityProperties>() in
styleForPage() has been deliberately left alone.
Animation properties are not used by callers of styleForPage()
and animation effects were not applied previously.

BUG=644148
==========

to

==========
Add CSS property priority for CSS animation affecting properties

This change adds a separate priority for CSS properties that affect
running animations. This is in preparation for enabling animation
of custom properties.

There is no meaningful change in behaviour made by this patch.

The reordering of CSSPropertyIDs has revealed a bug in CSS
property/SVG presentation attribute animation collision where the
"winner" is based on hash iteration ordering rather than
meaningful rules. This should not impact users in any significant
way as targeting SVG properties in Web Animations is still behind
the experimental flag.

The call to applyMatchedProperties<HighPriorityProperty>() in
styleForPage() has been deliberately left alone.
Animation properties are not used by callers of styleForPage()
and animation effects were not applied previously.

BUG=644148
==========

[Timothy Loh, 2016-10-24 05:33:05]

lgtm

[alancutter (OOO until 2018), 2016-10-25 03:40:49]

Not lgtm, this causes a 2-3% regression in the update_style metric.
http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-10...

[alancutter (OOO until 2018), 2016-11-04 04:33:18]

On 2016/10/25 at 03:40:49, alancutter wrote:
> Not lgtm, this causes a 2-3% regression in the update_style metric.
>
http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-10...

An optimisation patch has landed that addresses the performance regression in
this patch. Going to wait a couple of days for the perf bots to settle after
that change before landing this one.

[alancutter (OOO until 2018), 2016-11-11 11:46:16]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 11:46:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 13:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 13:26:46]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2016-11-12 00:25:52]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-11-12 00:25:52]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2317903003/#ps120001
(title: "Rebase onto latest optimisation")

[commit-bot: I haz the power, 2016-11-12 00:26:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 00:32:02]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-12 00:36:20]

Description was changed from

==========
Add CSS property priority for CSS animation affecting properties

This change adds a separate priority for CSS properties that affect
running animations. This is in preparation for enabling animation
of custom properties.

There is no meaningful change in behaviour made by this patch.

The reordering of CSSPropertyIDs has revealed a bug in CSS
property/SVG presentation attribute animation collision where the
"winner" is based on hash iteration ordering rather than
meaningful rules. This should not impact users in any significant
way as targeting SVG properties in Web Animations is still behind
the experimental flag.

The call to applyMatchedProperties<HighPriorityProperty>() in
styleForPage() has been deliberately left alone.
Animation properties are not used by callers of styleForPage()
and animation effects were not applied previously.

BUG=644148
==========

to

==========
Add CSS property priority for CSS animation affecting properties

This change adds a separate priority for CSS properties that affect
running animations. This is in preparation for enabling animation
of custom properties.

There is no meaningful change in behaviour made by this patch.

The reordering of CSSPropertyIDs has revealed a bug in CSS
property/SVG presentation attribute animation collision where the
"winner" is based on hash iteration ordering rather than
meaningful rules. This should not impact users in any significant
way as targeting SVG properties in Web Animations is still behind
the experimental flag.

The call to applyMatchedProperties<HighPriorityProperty>() in
styleForPage() has been deliberately left alone.
Animation properties are not used by callers of styleForPage()
and animation effects were not applied previously.

BUG=644148

Committed: https://crrev.com/6d47d44ba4c0ba026223adb94d7f236fbc5efa22
Cr-Commit-Position: refs/heads/master@{#431706}
==========

[commit-bot: I haz the power, 2016-11-12 00:36:22]

Patchset 7 (id:??) landed as
https://crrev.com/6d47d44ba4c0ba026223adb94d7f236fbc5efa22
Cr-Commit-Position: refs/heads/master@{#431706}