Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1720)

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

Issue 2317903003: Add CSS property priority for CSS animation affecting properties (Closed)
Patch Set: Rebase onto latest optimisation Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
index 03392eb874d8bb9dc5ca8eff13759b1e3af8d8fc..6728de8b0b262a4aac054086561869958ab5eea6 100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
@@ -844,6 +844,13 @@ void CSSAnimations::cancel() {
clearPendingUpdate();
}
+// TODO(alancutter): CSS properties and presentation attributes may have
+// identical effects. By grouping them in the same set we introduce a bug where
+// arbitrary hash iteration will determine the order the apply in and thus which
+// one "wins". We should be more deliberate about the order of application in
+// the case of effect collisions.
+// Example: Both 'color' and 'svg-color' set the color on ComputedStyle but are
+// considered distinct properties in the ActiveInterpolationsMap.
static bool isStylePropertyHandle(const PropertyHandle& propertyHandle) {
return propertyHandle.isCSSProperty() ||
propertyHandle.isPresentationAttribute();

Powered by Google App Engine
This is Rietveld 408576698