chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java - Issue 2317893002: [Offline Pages] Close race condition of multiple StartProcessing callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java

Issue 2317893002: [Offline Pages] Close race condition of multiple StartProcessing callers. (Closed)

Patch Set: Pete feedback - clear starting flag in deadbeat timeout case Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java

index 1df2c12d6ff2ff129ea7d5bbe32d0818a5a2f054..5fc9e8617eb78b24ae2b93d16b2d6e4004fa649a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java

@@ -100,6 +100,9 @@ public class BackgroundOfflinerTask {

};

// Pass the activation on to the bridge to the C++ RequestCoordinator.

- mBridge.startProcessing(deviceConditions, callback);

+ if (!mBridge.startProcessing(deviceConditions, callback)) {

+ // Processing not started currently. Let callback know.

+ callback.onResult(false);

+ }

}