[Offline Pages] Close race condition of multiple StartProcessing callers.

chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java

Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java
index eeab851d169eae31db32ee8e6f157bfc3297cb30..b5b48af0d122557b380cf7169082460bb7bff130 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java
@@ -11,21 +11,36 @@ import org.chromium.chrome.browser.offlinepages.interfaces.BackgroundSchedulerPr
  * Custom stub for our own BackgroundSchedulerRequestProcessor.
  */
 public class StubBackgroundSchedulerProcessor implements BackgroundSchedulerProcessor {
-    private boolean mStartProcessingCalled;
+    private boolean mFailToStart;
+    private boolean mDidStartProcessing;

[Pete Williamson, 2016/09/07 00:16:31]

Should these two variables get initialized to false somewhere?  Even 8if Java
does that for us by default, it would be nice to be explicit here.

[dougarnett, 2016/09/07 00:41:29]

Not doing this for members defaults got pounded in me in old google java reviews
and I ended up liking it. I don't find any current rule about it though.

     private DeviceConditions mDeviceConditions;
+    private Callback<Boolean> mCallback;
 
-    public boolean getStartProcessingCalled() {
-        return mStartProcessingCalled;
+    public void setFailToStart(boolean failToStart) {
+        mFailToStart = failToStart;
+    }
+
+    public boolean getDidStartProcessing() {
+        return mDidStartProcessing;
     }
 
     public DeviceConditions getDeviceConditions() {
         return mDeviceConditions;
     }
 
+    public void callback() {
+        mCallback.onResult(true);
+    }
+
     @Override
     public boolean startProcessing(DeviceConditions deviceConditions, Callback<Boolean> callback) {
-        mStartProcessingCalled = true;
+        if (mFailToStart) {
+            return false;
+        }
+
+        mDidStartProcessing = true;
         mDeviceConditions = deviceConditions;
+        mCallback = callback;
         return true;
     }
 }