Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 2317793002: [Password Manager] Remove "Nope" button from update passwords UI on iOS (Closed)

Created:
4 years, 3 months ago by Jackie Quinn
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Remove "Nope" button from update passwords UI on iOS Removes "Nope" button from the update passwords infobar on iOS, as specified by the updated design: https://folio.googleplex.com/chrome-ux/mocks/321-password-manager/password%20update/mobile BUG=642910 Review-Url: https://codereview.chromium.org/2295133003 Cr-Commit-Position: refs/heads/master@{#416114} (cherry picked from commit b988c041a2b9886b42cdd36cb0d904d84478da21) Committed: https://chromium.googlesource.com/chromium/src/+/d5389894fd03abe5a25d7dd3cec6a06a8df9999c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Jackie Quinn
4 years, 3 months ago (2016-09-06 19:29:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d5389894fd03abe5a25d7dd3cec6a06a8df9999c (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698