[Password Manager] Remove "Nope" button from update passwords UI on iOS

[Password Manager] Remove "Nope" button from update passwords UI on iOS

Removes "Nope" button from the update passwords infobar on iOS, as
specified by the updated design:
https://folio.googleplex.com/chrome-ux/mocks/321-password-manager/password%20update/mobile

BUG=642910
Committed: https://crrev.com/b988c041a2b9886b42cdd36cb0d904d84478da21
Cr-Commit-Position: refs/heads/master@{#416114}

[Jackie Quinn, 2016-08-31 21:48:13]

jyquinn@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2016-09-01 07:32:09]

Thanks, Jackie!
LGTM with two minor comments.

Cheers,
Vaclav

https://codereview.chromium.org/2295133003/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
(left):

https://codereview.chromium.org/2295133003/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm:91:
: IDS_IOS_PASSWORD_MANAGER_CANCEL_BUTTON);
Should we also drop this string from ios/chrome/app/strings/ios_strings.grd ?

https://codereview.chromium.org/2295133003/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
(right):

https://codereview.chromium.org/2295133003/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm:93:
DCHECK(button == BUTTON_OK);
nit: DCHECK_EQ(BUTTON_OK, button);

[Jackie Quinn, 2016-09-01 21:31:39]

jyquinn@chromium.org changed reviewers:
+ rohitrao@chromium.org

[Jackie Quinn, 2016-09-01 21:31:39]

+rohitrao for strings owners

https://codereview.chromium.org/2295133003/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
(left):

https://codereview.chromium.org/2295133003/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm:91:
: IDS_IOS_PASSWORD_MANAGER_CANCEL_BUTTON);
On 2016/09/01 07:32:09, vabr (OOO until 5 Sep) wrote:
> Should we also drop this string from ios/chrome/app/strings/ios_strings.grd ?

Good call. Done.

https://codereview.chromium.org/2295133003/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
(right):

https://codereview.chromium.org/2295133003/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm:93:
DCHECK(button == BUTTON_OK);
On 2016/09/01 07:32:09, vabr (OOO until 5 Sep) wrote:
> nit: DCHECK_EQ(BUTTON_OK, button);

Done.

[vabr (Chromium), 2016-09-01 21:47:51]

Thanks, LGTM!
Vaclav

[rohitrao (ping after 24h), 2016-09-01 22:25:42]

lgtm

[Jackie Quinn, 2016-09-01 22:27:23]

The CQ bit was checked by jyquinn@chromium.org

[commit-bot: I haz the power, 2016-09-01 22:28:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 23:20:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-01 23:21:33]

Description was changed from

==========
[Password Manager] Remove "Nope" button from update passwords UI on iOS

Removes "Nope" button from the update passwords infobar on iOS, as
specified by the updated design:
https://folio.googleplex.com/chrome-ux/mocks/321-password-manager/password%20...

BUG=642910
==========

to

==========
[Password Manager] Remove "Nope" button from update passwords UI on iOS

Removes "Nope" button from the update passwords infobar on iOS, as
specified by the updated design:
https://folio.googleplex.com/chrome-ux/mocks/321-password-manager/password%20...

BUG=642910

Committed: https://crrev.com/b988c041a2b9886b42cdd36cb0d904d84478da21
Cr-Commit-Position: refs/heads/master@{#416114}
==========

[commit-bot: I haz the power, 2016-09-01 23:21:34]

Patchset 3 (id:??) landed as
https://crrev.com/b988c041a2b9886b42cdd36cb0d904d84478da21
Cr-Commit-Position: refs/heads/master@{#416114}