Fix bluetooth callback function declaration

Fix bluetooth callback function declaration

The PFNBLUETOOTH_GATT_EVENT_CALLBACK typedef has been incorrect for
years and was fixed in the Windows 10.0.14393 SDK. This leads to
compile errors when building with this SDK. The incorrect function
declaration is missing CALLBACK which can lead to stack mismatches
so fixing the code to use the new declaration is important. A fixed
typedef needs to be used throughout Chromium to ensure consistent
stack cleanup. A cast is needed when calling into Windows (so that
Chrome will continue to build with the Windows 10.0.10586 SDK) and
that is the only time that the SDK supplied typedef should be used.

BUG=644321
Committed: https://crrev.com/2181e0ecc3172fc2a5f4eee62a125f784f5993f5
Cr-Commit-Position: refs/heads/master@{#418138}

[brucedawson, 2016-09-06 18:03:48]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 18:04:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-09-06 18:12:35]

Description was changed from

==========
Fix bluetooth callback function declaration

The PFNBLUETOOTH_GATT_EVENT_CALLBACK typedef has been incorrect for
years and was fixed in the Windows 10.0.14393 SDK. This leads to
compile errors when building with this SDK. The incorrect function
declaration is missing CALLBACK which can lead to stack mismatches
so fixing the code to use the new declaration is important. A cast
is needed so that Chrome will continue to build with the Windows
10.0.10586 SDK.

BUG=644321
==========

to

==========
Fix bluetooth callback function declaration

The PFNBLUETOOTH_GATT_EVENT_CALLBACK typedef has been incorrect for
years and was fixed in the Windows 10.0.14393 SDK. This leads to
compile errors when building with this SDK. The incorrect function
declaration is missing CALLBACK which can lead to stack mismatches
so fixing the code to use the new declaration is important. A cast
is needed so that Chrome will continue to build with the Windows
10.0.10586 SDK.

BUG=644321
==========

[brucedawson, 2016-09-06 18:12:36]

brucedawson@chromium.org changed reviewers:
+ scheib@chromium.org

[brucedawson, 2016-09-06 18:35:30]

PTAL

[commit-bot: I haz the power, 2016-09-06 21:57:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 21:57:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[scheib, 2016-09-07 00:48:42]

Thanks and LGTM

[scheib, 2016-09-07 00:49:00]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-09-07 00:49:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 04:24:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 04:24:35]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brucedawson, 2016-09-08 18:23:53]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-09-08 18:24:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 22:49:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:49:07]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brucedawson, 2016-09-09 01:14:32]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-09-09 01:14:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 03:06:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 03:06:29]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brucedawson, 2016-09-09 22:06:10]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-09-09 22:06:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-09-09 23:04:39]

The CQ bit was unchecked by brucedawson@chromium.org

[brucedawson, 2016-09-09 23:05:20]

I'd thought that the failures were test flakiness but now realize that they are
not. Two bluetooth tests crash reliably with this change. I can reproduce this
locally. Investigating...

[brucedawson, 2016-09-09 23:36:08]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 23:36:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-09-09 23:41:37]

Description was changed from

==========
Fix bluetooth callback function declaration

The PFNBLUETOOTH_GATT_EVENT_CALLBACK typedef has been incorrect for
years and was fixed in the Windows 10.0.14393 SDK. This leads to
compile errors when building with this SDK. The incorrect function
declaration is missing CALLBACK which can lead to stack mismatches
so fixing the code to use the new declaration is important. A cast
is needed so that Chrome will continue to build with the Windows
10.0.10586 SDK.

BUG=644321
==========

to

==========
Fix bluetooth callback function declaration

The PFNBLUETOOTH_GATT_EVENT_CALLBACK typedef has been incorrect for
years and was fixed in the Windows 10.0.14393 SDK. This leads to
compile errors when building with this SDK. The incorrect function
declaration is missing CALLBACK which can lead to stack mismatches
so fixing the code to use the new declaration is important. A fixed
typedef needs to be used throughout Chromium to ensure consistent
stack cleanup. A cast is needed when calling into Windows (so that
Chrome will continue to build with the Windows 10.0.10586 SDK) and
that is the only time that the SDK supplied typedef should be used.

BUG=644321
==========

[commit-bot: I haz the power, 2016-09-10 01:32:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 01:32:50]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-09-12 17:55:34]

The initial change fixed one calling convention mismatched but introduced
others. That was not progress.

This change fixes the mismatches. One cast is still needed but now it is at the
interface between our code and Windows, where it should be, and now all of the
tests pass, and the code builds with both SDKs.

PTAL at the new fix.

[scheib, 2016-09-12 19:28:16]

LGTM again. Also a comment suggestion:

https://codereview.chromium.org/2317773002/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_low_energy_win.h (right):

https://codereview.chromium.org/2317773002/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_low_energy_win.h:26: // modifier. This typedef should
be used throughout Chromium except when casting
Would be nice to include the 'why' you mention in the change description,
"CALLBACK which can lead to stack mismatches ... A fixed
typedef needs to be used throughout Chromium to ensure consistent
stack cleanup", in this comment.

[brucedawson, 2016-09-12 21:57:25]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2016-09-12 21:57:25]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2317773002/#ps60001
(title: "Updating typedef comment per code-review feedback")

[commit-bot: I haz the power, 2016-09-12 21:57:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 01:53:58]

Description was changed from

==========
Fix bluetooth callback function declaration

The PFNBLUETOOTH_GATT_EVENT_CALLBACK typedef has been incorrect for
years and was fixed in the Windows 10.0.14393 SDK. This leads to
compile errors when building with this SDK. The incorrect function
declaration is missing CALLBACK which can lead to stack mismatches
so fixing the code to use the new declaration is important. A fixed
typedef needs to be used throughout Chromium to ensure consistent
stack cleanup. A cast is needed when calling into Windows (so that
Chrome will continue to build with the Windows 10.0.10586 SDK) and
that is the only time that the SDK supplied typedef should be used.

BUG=644321
==========

to

==========
Fix bluetooth callback function declaration

The PFNBLUETOOTH_GATT_EVENT_CALLBACK typedef has been incorrect for
years and was fixed in the Windows 10.0.14393 SDK. This leads to
compile errors when building with this SDK. The incorrect function
declaration is missing CALLBACK which can lead to stack mismatches
so fixing the code to use the new declaration is important. A fixed
typedef needs to be used throughout Chromium to ensure consistent
stack cleanup. A cast is needed when calling into Windows (so that
Chrome will continue to build with the Windows 10.0.10586 SDK) and
that is the only time that the SDK supplied typedef should be used.

BUG=644321
==========

[commit-bot: I haz the power, 2016-09-13 01:54:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-13 01:56:10]

Description was changed from

==========
Fix bluetooth callback function declaration

The PFNBLUETOOTH_GATT_EVENT_CALLBACK typedef has been incorrect for
years and was fixed in the Windows 10.0.14393 SDK. This leads to
compile errors when building with this SDK. The incorrect function
declaration is missing CALLBACK which can lead to stack mismatches
so fixing the code to use the new declaration is important. A fixed
typedef needs to be used throughout Chromium to ensure consistent
stack cleanup. A cast is needed when calling into Windows (so that
Chrome will continue to build with the Windows 10.0.10586 SDK) and
that is the only time that the SDK supplied typedef should be used.

BUG=644321
==========

to

==========
Fix bluetooth callback function declaration

The PFNBLUETOOTH_GATT_EVENT_CALLBACK typedef has been incorrect for
years and was fixed in the Windows 10.0.14393 SDK. This leads to
compile errors when building with this SDK. The incorrect function
declaration is missing CALLBACK which can lead to stack mismatches
so fixing the code to use the new declaration is important. A fixed
typedef needs to be used throughout Chromium to ensure consistent
stack cleanup. A cast is needed when calling into Windows (so that
Chrome will continue to build with the Windows 10.0.10586 SDK) and
that is the only time that the SDK supplied typedef should be used.

BUG=644321

Committed: https://crrev.com/2181e0ecc3172fc2a5f4eee62a125f784f5993f5
Cr-Commit-Position: refs/heads/master@{#418138}
==========

[commit-bot: I haz the power, 2016-09-13 01:56:11]

Patchset 4 (id:??) landed as
https://crrev.com/2181e0ecc3172fc2a5f4eee62a125f784f5993f5
Cr-Commit-Position: refs/heads/master@{#418138}