Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2317723004: Fix for the chrome://cast hash logic to support page reloads that don't always take the user back t… (Closed)

Created:
4 years, 3 months ago by imcheng
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list. Old behavior: always navigate to the devices page when chrome://cast page loads. Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list. BUG=643701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2303133002 Cr-Commit-Position: refs/heads/master@{#416311} (cherry picked from commit e371fb2dc6cce53e784870abe6a959600a66db4e) Committed: https://chromium.googlesource.com/chromium/src/+/d129413c7f353d8e2e07409fa049271e4ba94b71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/cast/cast.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
imcheng
4 years, 3 months ago (2016-09-06 22:39:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d129413c7f353d8e2e07409fa049271e4ba94b71 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698