Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2303133002:
Fix for the chrome://cast hash logic to support page reloads. (Closed)
DescriptionFix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list.
Old behavior: always navigate to the devices page when chrome://cast page loads.
Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list.
BUG=643701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/e371fb2dc6cce53e784870abe6a959600a66db4e
Cr-Commit-Position: refs/heads/master@{#416311}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Fix for the chrome://cast hash logic to support page reloads. BUG= ========== to ========== Fix for the chrome://cast hash logic to support page reloads. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Fix for the chrome://cast hash logic to support page reloads. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Fix for the chrome://cast hash logic to support page reloads. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Fix for the chrome://cast hash logic to support page reloads. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Fix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list. Old behavior: always navigate to the devices page when chrome://cast page loads. Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list. BUG=643701 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
sheretov@chromium.org changed reviewers: + apacible@chromium.org
lgtm
The CQ bit was checked by sheretov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Your CL was about to rely on recently removed CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
tryserver.chromium.linux
For more details, see http://crbug.com/617627.
Description was changed from ========== Fix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list. Old behavior: always navigate to the devices page when chrome://cast page loads. Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list. BUG=643701 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Fix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list. Old behavior: always navigate to the devices page when chrome://cast page loads. Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list. BUG=643701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by sheretov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list. Old behavior: always navigate to the devices page when chrome://cast page loads. Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list. BUG=643701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list. Old behavior: always navigate to the devices page when chrome://cast page loads. Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list. BUG=643701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list. Old behavior: always navigate to the devices page when chrome://cast page loads. Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list. BUG=643701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix for the chrome://cast hash logic to support page reloads that don't always take the user back to the device list. Old behavior: always navigate to the devices page when chrome://cast page loads. Correct behavior: Look at the hash portion of the URL and mirror it to the extensionview guest, if present. If the URL does not have a hash, default to showing the device list. BUG=643701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e371fb2dc6cce53e784870abe6a959600a66db4e Cr-Commit-Position: refs/heads/master@{#416311} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e371fb2dc6cce53e784870abe6a959600a66db4e Cr-Commit-Position: refs/heads/master@{#416311} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
