[MD settings] display message about secondary install in default browser settings

[MD settings] display message about secondary install in default browser settings

This CL reworks the 'default browser' messages displayed in different
situations. The error icon has been removed to match the specs. A browser proxy
and unit tests have been added.

BUG=623328
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b18a04f5f5a16481ccb6693b2f8450dc1abb3735
Cr-Commit-Position: refs/heads/master@{#417327}

[dschuyler, 2016-09-07 00:43:37]

Description was changed from

==========
[MD settings] display message about secondary install in default browser
settings

This CL reworks the 'default browser' messages displayed in different
situations. The error icon has been removed to match the specs. A browser proxy
and unit tests have been added.

BUG=623328
==========

to

==========
[MD settings] display message about secondary install in default browser
settings

This CL reworks the 'default browser' messages displayed in different
situations. The error icon has been removed to match the specs. A browser proxy
and unit tests have been added.

BUG=623328
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-09-07 00:43:40]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 00:44:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-09-07 00:50:08]

dschuyler@chromium.org changed reviewers:
+ finnur@chromium.org

[dschuyler, 2016-09-07 00:50:09]

Please let me know if you'd rather have this CL 
split up (I could do the proxy and the unit tests
separately).

[commit-bot: I haz the power, 2016-09-07 01:38:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 01:38:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Finnur, 2016-09-07 16:25:22]

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/default_browser_page/default_browser_browser_proxy.js
(right):

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_browser_proxy.js:16:
*   }};
nit: Should this be indented?

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_browser_proxy.js:27:
*   'settings.updateDefaultBrowserState'.
nit: Same question here... I don't remember us indenting line two of multi-line
comments...

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_browser_proxy.js:34:
*   the settings will be sent to 'settings.updateDefaultBrowserState'.
ditto

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/default_browser_page/default_browser_page.html
(right):

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_page.html:3:
<link rel="import"
href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
This can go now, it seems.

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_page.html:4:
<link rel="import"
href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
What is this for?

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_page.html:26:
<template is="dom-if" if="[[!showButton_]]">
Button? Which button?

https://codereview.chromium.org/2317693003/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/default_browser_browsertest.js (right):

https://codereview.chromium.org/2317693003/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/default_browser_browsertest.js:1: // Copyright
2015 The Chromium Authors. All rights reserved.
nit: 2016

https://codereview.chromium.org/2317693003/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/default_browser_browsertest.js:46: * @param
{!DefaultBrowserInfo}
nit: Missing param name etc.

[Finnur, 2016-09-07 16:49:03]

> Please let me know if you'd rather have this CL split up

Nah, it's fine.

[dschuyler, 2016-09-07 18:32:32]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 18:33:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-09-07 18:51:42]

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/default_browser_page/default_browser_browser_proxy.js
(right):

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_browser_proxy.js:16:
*   }};
On 2016/09/07 16:25:22, Finnur wrote:
> nit: Should this be indented?

Done.

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_browser_proxy.js:27:
*   'settings.updateDefaultBrowserState'.
On 2016/09/07 16:25:22, Finnur wrote:
> nit: Same question here... I don't remember us indenting line two of
multi-line
> comments...

Done.

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_browser_proxy.js:34:
*   the settings will be sent to 'settings.updateDefaultBrowserState'.
On 2016/09/07 16:25:22, Finnur wrote:
> ditto

Done.

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/default_browser_page/default_browser_page.html
(right):

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_page.html:3:
<link rel="import"
href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
On 2016/09/07 16:25:22, Finnur wrote:
> This can go now, it seems.

Done.

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_page.html:4:
<link rel="import"
href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
On 2016/09/07 16:25:22, Finnur wrote:
> What is this for?

Done.

https://codereview.chromium.org/2317693003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/default_browser_page/default_browser_page.html:26:
<template is="dom-if" if="[[!showButton_]]">
On 2016/09/07 16:25:22, Finnur wrote:
> Button? Which button?

Done.

https://codereview.chromium.org/2317693003/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/default_browser_browsertest.js (right):

https://codereview.chromium.org/2317693003/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/default_browser_browsertest.js:1: // Copyright
2015 The Chromium Authors. All rights reserved.
On 2016/09/07 16:25:22, Finnur wrote:
> nit: 2016

Done.

https://codereview.chromium.org/2317693003/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/default_browser_browsertest.js:46: * @param
{!DefaultBrowserInfo}
On 2016/09/07 16:25:22, Finnur wrote:
> nit: Missing param name etc.

Done.

[commit-bot: I haz the power, 2016-09-07 20:13:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 20:13:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Finnur, 2016-09-07 21:34:05]

LGTM

[dschuyler, 2016-09-07 23:27:46]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 23:28:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:33:38]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dschuyler, 2016-09-07 23:37:01]

Made a small change to exclude the default browser
tests from chromeos.

[Finnur, 2016-09-08 11:27:05]

Still LGTM

[dschuyler, 2016-09-08 16:53:17]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-09-08 16:53:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 17:37:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 17:41:02]

Description was changed from

==========
[MD settings] display message about secondary install in default browser
settings

This CL reworks the 'default browser' messages displayed in different
situations. The error icon has been removed to match the specs. A browser proxy
and unit tests have been added.

BUG=623328
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] display message about secondary install in default browser
settings

This CL reworks the 'default browser' messages displayed in different
situations. The error icon has been removed to match the specs. A browser proxy
and unit tests have been added.

BUG=623328
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b18a04f5f5a16481ccb6693b2f8450dc1abb3735
Cr-Commit-Position: refs/heads/master@{#417327}
==========

[commit-bot: I haz the power, 2016-09-08 17:41:03]

Patchset 3 (id:??) landed as
https://crrev.com/b18a04f5f5a16481ccb6693b2f8450dc1abb3735
Cr-Commit-Position: refs/heads/master@{#417327}