chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2317693003: [MD settings] display message about secondary install in default browser settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2317693003: [MD settings] display message about secondary install in default browser settings (Closed)

Patch Set: excluding from chromeos Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_resources.grd ('k') | chrome/browser/ui/webui/settings/settings_default_browser_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index 0711fdd767d69f54ea08ccfa3264c3473a8e7c6b..33093979169fee3f8c3bd06e5c615b18f55d34c4 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -464,9 +464,8 @@ void AddDefaultBrowserStrings(content::WebUIDataSource* html_source) {

{"defaultBrowser", IDS_SETTINGS_DEFAULT_BROWSER},

{"defaultBrowserDefault", IDS_SETTINGS_DEFAULT_BROWSER_DEFAULT},

{"defaultBrowserMakeDefault", IDS_SETTINGS_DEFAULT_BROWSER_MAKE_DEFAULT},

- {"defaultBrowserUnknown", IDS_SETTINGS_DEFAULT_BROWSER_UNKNOWN},

+ {"defaultBrowserError", IDS_SETTINGS_DEFAULT_BROWSER_ERROR},

{"defaultBrowserSecondary", IDS_SETTINGS_DEFAULT_BROWSER_SECONDARY},

- {"unableToSetDefaultBrowser", IDS_SETTINGS_DEFAULT_BROWSER_ERROR},

};

AddLocalizedStringsBulk(html_source, localized_strings,

arraysize(localized_strings));

@@ -1151,7 +1150,7 @@ void AddSearchInSettingsStrings(content::WebUIDataSource* html_source) {

LocalizedString localized_strings[] = {

{"searchPrompt", IDS_SETTINGS_SEARCH_PROMPT},

{"searchNoResults", IDS_SETTINGS_SEARCH_NO_RESULTS},

- // TODO(dpapad); IDS_DOWNLOAD_CLEAR_SEARCH and IDS_MD_HISTORY_CLEAR_SEARCH

+ // TODO(dpapad): IDS_DOWNLOAD_CLEAR_SEARCH and IDS_MD_HISTORY_CLEAR_SEARCH

// are identical, merge them to one and re-use here.

{"clearSearch", IDS_DOWNLOAD_CLEAR_SEARCH},

};