Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2317683002: Revert of Move uils and sksl to a common sources GYP file. (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 3 months ago
Reviewers:
brettw, mtklein_C
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move uils and sksl to a common sources GYP file. (patchset #1 id:1 of https://codereview.chromium.org/2302723005/ ) Reason for revert: The broke the PDFium build. See https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-PDFium/builds/2094 Original issue's description: > Move uils and sksl to a common sources GYP file. > > This is for the coalescing of sources in one GYP file to improve GN runtime. If > this is successful, the other sources lists will also be merged into this one > file. > > Inlines "../src" and "../include" for skia_source_dir and skia_include_dir. Evaluating these with GYP's variable expansion is annoying since I think another layer of nesting is required. Coding these explicitly is also more clear. This used to be required because Chromium would reference these .gypi files directly with a different path, but this no longer happens. > > Removes the chromium defines gypi which is no longer referenced. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302723005 > > Committed: https://skia.googlesource.com/skia/+/39f7a10a04a914384944d8bf62621144ac4eeaa3 TBR=mtklein@chromium.org,brettw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://skia.googlesource.com/skia/+/e6088c6063b60f58411936af9c48841131a5e001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -155 lines) Patch
M gn/shared_sources.gni View 1 chunk +18 lines, -5 lines 0 comments Download
A gyp/skia_for_chromium_defines.gypi View 1 chunk +22 lines, -0 lines 0 comments Download
D gyp/skia_sources.gypi View 1 chunk +0 lines, -136 lines 0 comments Download
M gyp/sksl.gyp View 1 chunk +3 lines, -5 lines 0 comments Download
A gyp/sksl.gypi View 1 chunk +22 lines, -0 lines 0 comments Download
M gyp/skslc.gyp View 1 chunk +3 lines, -5 lines 0 comments Download
M gyp/utils.gyp View 3 chunks +4 lines, -4 lines 0 comments Download
A gyp/utils.gypi View 1 chunk +120 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
caryclark
Created Revert of Move uils and sksl to a common sources GYP file.
4 years, 3 months ago (2016-09-06 13:38:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317683002/1
4 years, 3 months ago (2016-09-06 13:38:58 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 14:07:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e6088c6063b60f58411936af9c48841131a5e001

Powered by Google App Engine
This is Rietveld 408576698