Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2302723005: Move uils and sksl to a common sources GYP file. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
mtklein_C
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move uils and sksl to a common sources GYP file. This is for the coalescing of sources in one GYP file to improve GN runtime. If this is successful, the other sources lists will also be merged into this one file. Inlines "../src" and "../include" for skia_source_dir and skia_include_dir. Evaluating these with GYP's variable expansion is annoying since I think another layer of nesting is required. Coding these explicitly is also more clear. This used to be required because Chromium would reference these .gypi files directly with a different path, but this no longer happens. Removes the chromium defines gypi which is no longer referenced. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302723005 Committed: https://skia.googlesource.com/skia/+/39f7a10a04a914384944d8bf62621144ac4eeaa3 Committed: https://skia.googlesource.com/skia/+/45d1b442f1e0402ad7bc6a333ab86b32648c7a8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -192 lines) Patch
M gn/shared_sources.gni View 1 chunk +5 lines, -18 lines 0 comments Download
D gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -22 lines 0 comments Download
A gyp/skia_sources.gypi View 1 chunk +136 lines, -0 lines 0 comments Download
M gyp/sksl.gyp View 1 chunk +5 lines, -3 lines 0 comments Download
D gyp/sksl.gypi View 1 chunk +0 lines, -22 lines 0 comments Download
M gyp/skslc.gyp View 1 chunk +5 lines, -3 lines 0 comments Download
M gyp/utils.gyp View 3 chunks +4 lines, -4 lines 0 comments Download
D gyp/utils.gypi View 1 chunk +0 lines, -120 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
brettw
4 years, 3 months ago (2016-09-02 19:45:12 UTC) #7
mtklein_C
lgtm
4 years, 3 months ago (2016-09-02 21:00:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302723005/1
4 years, 3 months ago (2016-09-02 21:00:08 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/39f7a10a04a914384944d8bf62621144ac4eeaa3
4 years, 3 months ago (2016-09-02 21:01:10 UTC) #14
caryclark
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2317683002/ by caryclark@google.com. ...
4 years, 3 months ago (2016-09-06 13:38:51 UTC) #15
brettw
I updated pdfium: https://codereview.chromium.org/2316653003/ so I'm reopening this CL and relanding with no modifications.
4 years, 3 months ago (2016-09-06 19:08:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302723005/1
4 years, 3 months ago (2016-09-06 19:08:52 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 19:43:58 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/45d1b442f1e0402ad7bc6a333ab86b32648c7a8c

Powered by Google App Engine
This is Rietveld 408576698